From: Michal Hocko <mhocko@suse.cz>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Patch v2] freezer: check OOM kill while being frozen
Date: Wed, 13 Aug 2014 11:26:59 +0200 [thread overview]
Message-ID: <20140813092659.GA2775@dhcp22.suse.cz> (raw)
In-Reply-To: <CAM_iQpUtvqnaSuzO9d+HSDhEwtwjP9J5JaZwYusdW157zCdhRw@mail.gmail.com>
On Tue 12-08-14 17:53:33, Cong Wang wrote:
> On Tue, Aug 12, 2014 at 4:44 AM, Michal Hocko <mhocko@suse.cz> wrote:
[...]
> >> @@ -147,12 +156,6 @@ void __thaw_task(struct task_struct *p)
> >> {
> >> unsigned long flags;
> >>
> >> - /*
> >> - * Clear freezing and kick @p if FROZEN. Clearing is guaranteed to
> >> - * be visible to @p as waking up implies wmb. Waking up inside
> >> - * freezer_lock also prevents wakeups from leaking outside
> >> - * refrigerator.
> >> - */
> >
> > This is an unrelated change.
> >
>
> It is, because as I explained, __thaw_task() doesn't do what this comment
> says therefore needs this patch. Or you prefer to make it a separated patch?
It is outdated since a3201227f803. I would do it in a separate patch but
maybe just mention that the above commit has changed the implementation.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2014-08-13 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 0:53 Cong Wang
2014-08-12 0:53 ` [Patch] x86,mm: check freeze request in page fault handler Cong Wang
2014-08-12 12:09 ` Michal Hocko
2014-08-13 0:47 ` Cong Wang
2014-08-13 9:36 ` Michal Hocko
2014-08-14 0:26 ` Cong Wang
2014-08-15 8:36 ` Michal Hocko
2014-08-12 11:44 ` [Patch v2] freezer: check OOM kill while being frozen Michal Hocko
2014-08-13 0:53 ` Cong Wang
2014-08-13 9:26 ` Michal Hocko [this message]
2014-08-14 0:16 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813092659.GA2775@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=tj@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®