mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: pci: ctxfi: fix broken user-visible string
Date: Tue, 26 Aug 2014 19:04:20 +0530	[thread overview]
Message-ID: <20140826133420.GB21572@sudip-PC> (raw)
In-Reply-To: <s5hegw35t4r.wl-tiwai@suse.de>

On Tue, Aug 26, 2014 at 02:32:04PM +0200, Takashi Iwai wrote:
> At Tue, 26 Aug 2014 17:52:14 +0530,
> Sudip Mukherjee wrote:
> > 
> > fixed broken user visible strings
> 
> This text just repeats what the summary line says.  Instead, you
> should write *why* the patch is needed.  Ditto for the previous
> patch.
> 

Hi,
Resent both the patches , and also modified the changelog . Can you please review them again ...

thanks
sudip

> 
> 
> Takashi

  reply	other threads:[~2014-08-26 13:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[PATCH] sound: pci: ctxfi: prink replacement>
2014-08-26 12:22 ` Sudip Mukherjee
2014-08-26 12:32   ` Takashi Iwai
2014-08-26 13:34     ` Sudip Mukherjee [this message]
2014-08-26 13:41       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140826133420.GB21572@sudip-PC \
    --to=sudipm.mukherjee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®