From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Chris Zhong <zyw@rock-chips.com>,
dianders@chromium.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, sameo@linux.intel.com,
lee.jones@linaro.org, lgirdwood@gmail.com, a.zummo@towertech.it,
mturquette@linaro.org, akpm@linux-foundation.org,
broonie@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
grant.likely@linaro.org, hl@rock-chips.com,
huangtao@rock-chips.com, cf@rock-chips.com,
zhangqing@rock-chips.com, xxx@rock-chips.com, olof@lixom.net,
sonnyrao@chromium.org, javier.martinez@collabora.co.uk,
kever.yang@rock-chips.com
Subject: Re: [PATCH v9 2/3] clk: RK808: Add clkout driver for RK808
Date: Thu, 4 Sep 2014 11:34:21 -0700 [thread overview]
Message-ID: <20140904183421.GE10224@core.coreip.homeip.net> (raw)
In-Reply-To: <3708545.id8zLgF0vo@diego>
On Thu, Sep 04, 2014 at 08:02:56PM +0200, Heiko Stübner wrote:
> Am Donnerstag, 4. September 2014, 10:40:24 schrieb Dmitry Torokhov:
> > Hi Chris,
> >
> > On Thu, Sep 04, 2014 at 09:12:38AM +0800, Chris Zhong wrote:
> > > + rk808_clkout->clk_data.clks = clk_table;
> > > + rk808_clkout->clk_data.clk_num = RK808_NR_OUTPUT;
> > > +
> > > + return of_clk_add_provider(node, of_clk_src_onecell_get,
> > > + &rk808_clkout->clk_data);
> > > +}
> > > +
> > > +static struct platform_driver rk808_clkout_driver = {
> > > + .probe = rk808_clkout_probe,
> > > + .driver = {
> > > + .name = "rk808-clkout",
> > > + },
> > > +};
> >
> > Shouldn't there also be:
> >
> > static int rk808_clkout_probe(struct platform_device *pdev)
> ^^ remove
>
> Just to prevent confusion. And you're right there of course.
Ah, yes, stupid cut-and-paste...
--
Dmitry
next prev parent reply other threads:[~2014-09-04 18:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 1:12 [PATCH v9 0/3] Add rockchip RK808 pmic driver Chris Zhong
2014-09-04 1:12 ` [PATCH v9 1/3] RTC: RK808: add RTC driver for RK808 Chris Zhong
2014-09-04 4:18 ` Doug Anderson
2014-09-04 17:33 ` Dmitry Torokhov
2014-09-04 19:04 ` Doug Anderson
2014-09-04 20:08 ` Dmitry Torokhov
2014-09-04 1:12 ` [PATCH v9 2/3] clk: RK808: Add clkout " Chris Zhong
2014-09-04 17:40 ` Dmitry Torokhov
2014-09-04 18:02 ` Heiko Stübner
2014-09-04 18:34 ` Dmitry Torokhov [this message]
2014-09-05 1:35 ` Mike Turquette
2014-09-04 1:12 ` [PATCH v9 3/3] regulator: RK808: Remove pdata from the regulator Chris Zhong
2014-09-04 4:21 ` Doug Anderson
2014-09-04 19:07 ` Doug Anderson
2014-09-09 11:45 ` [PATCH v9 0/3] Add rockchip RK808 pmic driver Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904183421.GE10224@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kever.yang@rock-chips.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=sonnyrao@chromium.org \
--cc=xxx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®