* [PATCH] drivers: target: target_core_transport.c: build warning
@ 2014-09-09 7:23 Sudip Mukherjee
2014-09-09 7:32 ` Sudip Mukherjee
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2014-09-09 7:23 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: Sudip Mukherjee, linux-scsi, target-devel, linux-kernel
build is giving :
warning: passing argument 1 of 'strlen' makes pointer from integer
without a cast [enabled by default]
the snprintf after the strlen is trying to put the "Unsupported" string
at the end of exising string. so len should give the string length here
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/target/target_core_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 1dd1181..3ce85ed 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -953,7 +953,7 @@ int transport_dump_vpd_ident_type(
strlcat(buf, "SCSI name string\n", sizeof(buf));
break;
default:
- len = strlen(len);
+ len = strlen(buf);
snprintf(&buf[len], sizeof(buf) - len, "Unsupported: 0x%02x\n",
vpd->device_identifier_type);
ret = -EINVAL;
--
1.8.1.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: target: target_core_transport.c: build warning
2014-09-09 7:23 [PATCH] drivers: target: target_core_transport.c: build warning Sudip Mukherjee
@ 2014-09-09 7:32 ` Sudip Mukherjee
0 siblings, 0 replies; 2+ messages in thread
From: Sudip Mukherjee @ 2014-09-09 7:32 UTC (permalink / raw)
To: Nicholas A. Bellinger; +Cc: linux-scsi, target-devel, linux-kernel
On Tue, Sep 09, 2014 at 12:53:50PM +0530, Sudip Mukherjee wrote:
> build is giving :
> warning: passing argument 1 of 'strlen' makes pointer from integer
> without a cast [enabled by default]
>
> the snprintf after the strlen is trying to put the "Unsupported" string
> at the end of exising string. so len should give the string length here
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/target/target_core_transport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 1dd1181..3ce85ed 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -953,7 +953,7 @@ int transport_dump_vpd_ident_type(
> strlcat(buf, "SCSI name string\n", sizeof(buf));
> break;
> default:
> - len = strlen(len);
> + len = strlen(buf);
> snprintf(&buf[len], sizeof(buf) - len, "Unsupported: 0x%02x\n",
> vpd->device_identifier_type);
> ret = -EINVAL;
> --
> 1.8.1.2
>
please discard this patch. This is based on next-20140908 , and the
issue has been corrected in next-20140909.
thanks
sudip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-09 7:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-09 7:23 [PATCH] drivers: target: target_core_transport.c: build warning Sudip Mukherjee
2014-09-09 7:32 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®