From: Mark Brown <broonie@kernel.org>
To: jiwang <jiada_wang@mentor.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
"Frkuska, Joshua" <Joshua_Frkuska@mentor.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: question about two ASoC commits
Date: Tue, 9 Sep 2014 11:19:54 +0100 [thread overview]
Message-ID: <20140909101954.GO2601@sirena.org.uk> (raw)
In-Reply-To: <540EBC14.6090002@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Tue, Sep 09, 2014 at 05:36:36PM +0900, jiwang wrote:
> Can anyone tell me what is the reasoning of the following two commits
> commit: 5d16333 ASoC: SND_SOC_DAIFMT_NB_NF become 0 as default settings
> commit: eef28e1 ASoC: SND_SOC_DAIFMT_GATED become 0 as default settings
> with these two commits, now we have
> #define SND_SOC_DAIFMT_GATED (0 << 4)
> #define SND_SOC_DAIFMT_NB_NF (0 << 8)
> in soc-dai.h
> what's the good to shift 0 with different numbers?
> no matter the number, they both equal to 0.
> IMO all bit flags which share same variable (in this case SND_SOC_DAIFMT)
> should have different value, isn't it?
As the commit message says this is so that we have a default value which
does something sensible.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
parent reply other threads:[~2014-09-09 10:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <540EBC14.6090002@mentor.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909101954.GO2601@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Joshua_Frkuska@mentor.com \
--cc=alsa-devel@alsa-project.org \
--cc=jiada_wang@mentor.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®