* Re: question about two ASoC commits
[not found] <540EBC14.6090002@mentor.com>
@ 2014-09-09 10:19 ` Mark Brown
0 siblings, 0 replies; only message in thread
From: Mark Brown @ 2014-09-09 10:19 UTC (permalink / raw)
To: jiwang
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Frkuska, Joshua,
alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Tue, Sep 09, 2014 at 05:36:36PM +0900, jiwang wrote:
> Can anyone tell me what is the reasoning of the following two commits
> commit: 5d16333 ASoC: SND_SOC_DAIFMT_NB_NF become 0 as default settings
> commit: eef28e1 ASoC: SND_SOC_DAIFMT_GATED become 0 as default settings
> with these two commits, now we have
> #define SND_SOC_DAIFMT_GATED (0 << 4)
> #define SND_SOC_DAIFMT_NB_NF (0 << 8)
> in soc-dai.h
> what's the good to shift 0 with different numbers?
> no matter the number, they both equal to 0.
> IMO all bit flags which share same variable (in this case SND_SOC_DAIFMT)
> should have different value, isn't it?
As the commit message says this is so that we have a default value which
does something sensible.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] only message in thread