[PATCH] rhashtable: remove duplicate comment.

[PATCH] rhashtable: remove duplicate comment.

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]



The second comment is identical to the earlier comment, just indented
a bit. This is confusing, so remove it.

Also expand that first comment to mention the splicing that happens.

Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index a2c78810ebc1..8fd2f21d022a 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -309,15 +309,12 @@ int rhashtable_shrink(struct rhashtable *ht, gfp_t flags)
 
 	/* Link each bucket in the new table to the first bucket
 	 * in the old table that contains entries which will hash
-	 * to the new bucket.
+	 * to the new bucket, and then splice in the second
+	 * bucket from the old table.
 	 */
 	for (i = 0; i < ntbl->size; i++) {
 		ntbl->buckets[i] = tbl->buckets[i];
 
-		/* Link each bucket in the new table to the first bucket
-		 * in the old table that contains entries which will hash
-		 * to the new bucket.
-		 */
 		for (pprev = &ntbl->buckets[i]; *pprev != NULL;
 		     pprev = &rht_dereference(*pprev, ht)->next)
 			;

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [PATCH] rhashtable: remove duplicate comment.

[Thomas Graf]

On 09/11/14 at 05:10pm, NeilBrown wrote:
> 
> 
> The second comment is identical to the earlier comment, just indented
> a bit. This is confusing, so remove it.
> 
> Also expand that first comment to mention the splicing that happens.
> 
> Signed-off-by: NeilBrown <neilb@suse.de>

Acked-by: Thomas Graf <tgraf@suug.ch>