mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] TPM: Add new TPMs to the tail of the list to prevent inadvertent change of dev
@ 2014-09-12  9:55 David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2014-09-12  9:55 UTC (permalink / raw)
  To: jmorris
  Cc: dhowells, linux-kernel, stable, Jason Gunthorpe,
	linux-security-module, tpmdd-devel, Peter Huewe

Add newly registered TPMs to the tail of the list, not the beginning, so that
things that are specifying TPM_ANY_NUM don't find that the device they're
using has inadvertently changed.  Adding a second device would break IMA, for
instance.

Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
cc: stable@vger.kernel.org
---

 drivers/char/tpm/tpm-interface.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
index 6af17002a115..cfb9089887bd 100644
--- a/drivers/char/tpm/tpm-interface.c
+++ b/drivers/char/tpm/tpm-interface.c
@@ -1122,7 +1122,7 @@ struct tpm_chip *tpm_register_hardware(struct device *dev,
 
 	/* Make chip available */
 	spin_lock(&driver_lock);
-	list_add_rcu(&chip->list, &tpm_chip_list);
+	list_add_tail_rcu(&chip->list, &tpm_chip_list);
 	spin_unlock(&driver_lock);
 
 	return chip;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-09-12  9:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-12  9:55 [PATCH] TPM: Add new TPMs to the tail of the list to prevent inadvertent change of dev David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®