mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Jan Kara <jack@suse.cz>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] printk: git rid of [sched_delayed] message for printk_deferred
Date: Tue, 16 Sep 2014 15:14:15 -0400	[thread overview]
Message-ID: <20140916151415.4c646cbc@gandalf.local.home> (raw)
In-Reply-To: <20140916152046.GC32118@x4>

On Tue, 16 Sep 2014 17:20:46 +0200
Markus Trippelsdorf <markus@trippelsdorf.de> wrote:

> On 2014.09.16 at 11:13 -0400, Steven Rostedt wrote
> I'll leave it to you. This is just a cosmetic issue, so there's no need
> to fix this immediately.
> 

Actually the fix is much simpler (I had to wait for the drugs to wear
off before I noticed this ;-):


>From 2a88421634bf7a5238b18d829c64f8fd59f12aab Mon Sep 17 00:00:00 2001
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
Date: Tue, 16 Sep 2014 15:08:24 -0400
Subject: [PATCH] timer: Remove redundant log level from printk_deferred() call

printk_deferred() is only used in critical sections that is unsafe to
call printk() directly, and these prints are for warnings only. They
do not take a printk loglevel (KERN_*) in their formats. A KERN_WARNING
is assumed and applied by the call itself.

Cc: Jan Kara <jack@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org # 3.16+
Fixes: 504d58745c9c "timer: Fix lock inversion between hrtimer_bases.lock and scheduler locks"
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/time/clockevents.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 9c94c19f1305..0a7516e59610 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -146,8 +146,7 @@ static int clockevents_increase_min_delta(struct clock_event_device *dev)
 {
 	/* Nothing to do if we already reached the limit */
 	if (dev->min_delta_ns >= MIN_DELTA_LIMIT) {
-		printk_deferred(KERN_WARNING
-				"CE: Reprogramming failure. Giving up\n");
+		printk_deferred("CE: Reprogramming failure. Giving up\n");
 		dev->next_event.tv64 = KTIME_MAX;
 		return -ETIME;
 	}
@@ -160,8 +159,7 @@ static int clockevents_increase_min_delta(struct clock_event_device *dev)
 	if (dev->min_delta_ns > MIN_DELTA_LIMIT)
 		dev->min_delta_ns = MIN_DELTA_LIMIT;
 
-	printk_deferred(KERN_WARNING
-			"CE: %s increased min_delta_ns to %llu nsec\n",
+	printk_deferred("CE: %s increased min_delta_ns to %llu nsec\n",
 			dev->name ? dev->name : "?",
 			(unsigned long long) dev->min_delta_ns);
 	return 0;
-- 
1.8.1.4


  reply	other threads:[~2014-09-16 19:14 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-14  5:09 Weird character in kernel message Markus Trippelsdorf
2014-09-14  5:54 ` Markus Trippelsdorf
2014-09-14  9:13   ` Geert Uytterhoeven
2014-09-15 16:37     ` Markus Trippelsdorf
2014-09-16 10:55       ` Jan Kara
2014-09-16 14:42         ` [PATCH] printk: git rid of [sched_delayed] message for printk_deferred Markus Trippelsdorf
2014-09-16 15:13           ` Steven Rostedt
2014-09-16 15:20             ` Markus Trippelsdorf
2014-09-16 19:14               ` Steven Rostedt [this message]
2014-09-16 19:17                 ` Markus Trippelsdorf
2014-09-16 20:26                   ` Steven Rostedt
2014-09-16 20:35             ` Jan Kara
2014-09-16 21:07               ` Steven Rostedt
2014-09-16 21:22                 ` Jan Kara
2014-09-16 21:33                   ` Steven Rostedt
2014-09-17 14:18                     ` Peter Zijlstra
2014-09-17 14:22                       ` Steven Rostedt
2014-09-17 22:36                         ` Peter Zijlstra
2014-09-18  0:31                           ` Steven Rostedt
2014-09-18 17:34                             ` Peter Zijlstra
2014-09-20  5:12                               ` Jan Kara
2014-09-20 15:32                                 ` Steven Rostedt
2014-09-20 16:34                                   ` Markus Trippelsdorf
2014-09-20 15:47                                 ` Peter Zijlstra
2014-09-20 16:10                                   ` Joe Perches
2014-09-20 16:30                                     ` Steven Rostedt
2014-09-20 18:08                                       ` Peter Zijlstra
2014-09-20 18:01                                     ` Peter Zijlstra
2014-09-24 11:01                                   ` Jan Kara
2014-09-24 11:11                                     ` [PATCH v2] " Markus Trippelsdorf
2014-09-24 11:26                                       ` Jan Kara
2014-09-24 11:37                                         ` [PATCH v3] " Markus Trippelsdorf
2014-09-24 15:12                                           ` Steven Rostedt
2014-09-24 15:20 [PATCH] " Markus Trippelsdorf
2014-09-24 15:35 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140916151415.4c646cbc@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®