From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jan Kara <jack@suse.cz>,
Markus Trippelsdorf <markus@trippelsdorf.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] printk: git rid of [sched_delayed] message for printk_deferred
Date: Wed, 17 Sep 2014 16:18:16 +0200 [thread overview]
Message-ID: <20140917141816.GO2840@worktop.localdomain> (raw)
In-Reply-To: <20140916173328.6306a5c2@gandalf.local.home>
On Tue, Sep 16, 2014 at 05:33:28PM -0400, Steven Rostedt wrote:
> > printk_deffered() will be in order with other printks after your commit
> > 458df9fd4815b47809875d57f42e16401674b621. Just printing to console itself
> > will be delayed to the next timer interrupt. Or am I missing something?
>
> Hehe, you're right. I blame the meds for forgetting this.
>
> Yeah, my update will put the data in order. Thus I guess I agree with
> your assessment. We probably don't need the "sched_delayed" anymore.
>
> OK, you convinced me, but I still like to hear Peter's view on this
> before we commit it.
By not calling console_unlock() the messages will be 'delayed', as in,
we'll not call console->write() and we'll not see them, etc..
So some form of [delayed] or whatnot seems to remain appropriate.
I agree that the 'sched_' part has lived far beyond its relevance.
next prev parent reply other threads:[~2014-09-17 14:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 5:09 Weird character in kernel message Markus Trippelsdorf
2014-09-14 5:54 ` Markus Trippelsdorf
2014-09-14 9:13 ` Geert Uytterhoeven
2014-09-15 16:37 ` Markus Trippelsdorf
2014-09-16 10:55 ` Jan Kara
2014-09-16 14:42 ` [PATCH] printk: git rid of [sched_delayed] message for printk_deferred Markus Trippelsdorf
2014-09-16 15:13 ` Steven Rostedt
2014-09-16 15:20 ` Markus Trippelsdorf
2014-09-16 19:14 ` Steven Rostedt
2014-09-16 19:17 ` Markus Trippelsdorf
2014-09-16 20:26 ` Steven Rostedt
2014-09-16 20:35 ` Jan Kara
2014-09-16 21:07 ` Steven Rostedt
2014-09-16 21:22 ` Jan Kara
2014-09-16 21:33 ` Steven Rostedt
2014-09-17 14:18 ` Peter Zijlstra [this message]
2014-09-17 14:22 ` Steven Rostedt
2014-09-17 22:36 ` Peter Zijlstra
2014-09-18 0:31 ` Steven Rostedt
2014-09-18 17:34 ` Peter Zijlstra
2014-09-20 5:12 ` Jan Kara
2014-09-20 15:32 ` Steven Rostedt
2014-09-20 16:34 ` Markus Trippelsdorf
2014-09-20 15:47 ` Peter Zijlstra
2014-09-20 16:10 ` Joe Perches
2014-09-20 16:30 ` Steven Rostedt
2014-09-20 18:08 ` Peter Zijlstra
2014-09-20 18:01 ` Peter Zijlstra
2014-09-24 11:01 ` Jan Kara
2014-09-24 11:11 ` [PATCH v2] " Markus Trippelsdorf
2014-09-24 11:26 ` Jan Kara
2014-09-24 11:37 ` [PATCH v3] " Markus Trippelsdorf
2014-09-24 15:12 ` Steven Rostedt
2014-09-24 15:20 [PATCH] " Markus Trippelsdorf
2014-09-24 15:35 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917141816.GO2840@worktop.localdomain \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®