From: Borislav Petkov <bp@alien8.de>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Nadav Amit <namit@cs.technion.ac.il>,
Ingo Molnar <mingo@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
the arch/x86 maintainers <x86@kernel.org>,
kvm <kvm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RESEND PATCH 1/3] x86: Adding structs to reflect cpuid fields
Date: Thu, 18 Sep 2014 09:19:46 +0200 [thread overview]
Message-ID: <20140918071945.GA24842@nazgul.tnic> (raw)
In-Reply-To: <20140918002953.GA6918@potion.redhat.com>
On Thu, Sep 18, 2014 at 02:29:54AM +0200, Radim Krčmář wrote:
> I think you proposed to use magic constant in place of of MASK_FAM_X, so
Huh, what?
> Second problem: Most elements don't begin at offset 0, so the usual
> retrieval would add a shift, (repurposing max_monitor_line_size)
So what?
> max_monitor_line_size = (cpuid & MASK_FAM_X) >> OFFSET_FAM_X;
>
> and it's not better when we write it back after doing stuff.
Writing back CPUID on baremetal? You can't be serious.
Ok, this is getting ridiculous so I'll stop wasting time. I stand by my
initial statement - this is a bad idea.
--
Regards/Gruss,
Boris.
--
next prev parent reply other threads:[~2014-09-18 7:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1410870160-28845-1-git-send-email-namit@cs.technion.ac.il>
2014-09-16 13:22 ` [PATCH 0/3] x86: structs for cpuid info in x86 Ingo Molnar
2014-09-16 20:19 ` Nadav Amit
2014-09-17 12:37 ` Ingo Molnar
2014-09-17 12:45 ` Borislav Petkov
2014-09-17 12:54 ` [RESEND PATCH " Nadav Amit
2014-09-17 12:54 ` [RESEND PATCH 1/3] x86: Adding structs to reflect cpuid fields Nadav Amit
2014-09-17 13:21 ` Borislav Petkov
2014-09-17 13:53 ` Nadav Amit
2014-09-17 14:06 ` Borislav Petkov
2014-09-17 15:04 ` Radim Krčmář
2014-09-17 15:22 ` Borislav Petkov
2014-09-18 0:29 ` Radim Krčmář
2014-09-18 7:19 ` Borislav Petkov [this message]
2014-09-18 10:00 ` Radim Krčmář
2014-09-18 13:06 ` Paolo Bonzini
2014-09-18 13:26 ` Borislav Petkov
2014-09-18 13:36 ` Paolo Bonzini
2014-09-19 7:58 ` Borislav Petkov
2014-09-19 8:59 ` Nadav Amit
2014-09-19 10:32 ` Borislav Petkov
2014-09-19 13:40 ` Paolo Bonzini
2014-09-19 14:44 ` Borislav Petkov
2014-09-17 14:10 ` Peter Zijlstra
2014-09-17 12:54 ` [RESEND PATCH 2/3] x86: Use new cpuid structs in cpuid functions Nadav Amit
2014-09-17 12:54 ` [RESEND PATCH 3/3] KVM: x86: Using cpuid structs in KVM Nadav Amit
2014-09-17 14:12 ` [PATCH 0/3] x86: structs for cpuid info in x86 Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918071945.GA24842@nazgul.tnic \
--to=bp@alien8.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namit@cs.technion.ac.il \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®