From: Tejun Heo <tj@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: lizefan@huawei.com, peterz@infradead.org, mingo@kernel.org,
keescook@chromium.org, miaox@cn.fujitsu.com,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
rientjes@google.com
Subject: Re: [PATCH v3 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
Date: Wed, 24 Sep 2014 10:32:47 -0400 [thread overview]
Message-ID: <20140924143247.GF16555@htj.dyndns.org> (raw)
In-Reply-To: <201409242309.HDF95877.OSVFFtQLJMOHOF@I-love.SAKURA.ne.jp>
On Wed, Sep 24, 2014 at 11:09:25PM +0900, Tetsuo Handa wrote:
> Tejun Heo wrote:
> > > Applied 1-3 to cgroup/for-3.17-fixes w/ the typo spotted by davidr
> > > fixed.
>
> s/happend/happened/
>
> >
> > Reverted due to build failure. Will wait for a refreshed version. :(
>
> I can build with 1-3 patches using HEAD of linux.git. What failure did you see?
>
> $ make kernel/seccomp.o kernel/sys.o security/apparmor/domain.o kernel/cpuset.o
Got the following failure report from the build bot.
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-3.17-fixes
head: ed91a06989e253cde811d492414adcf94f34eb03
commit: ed91a06989e253cde811d492414adcf94f34eb03 [8/8] cpuset: PF_SPREAD_PAGE and PF_SPREAD_SLAB
+should be atomic flags
config: x86_64-randconfig-hxb2-0924 (attached as .config)
reproduce:
git checkout ed91a06989e253cde811d492414adcf94f34eb03
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings:
In file included from include/linux/linkage.h:4:0,
from include/linux/preempt.h:9,
from include/linux/spinlock.h:50,
from include/linux/mmzone.h:7,
from include/linux/gfp.h:5,
from include/linux/slab.h:14,
from mm/slab.c:89:
mm/slab.c: In function '__do_cache_alloc':
>> mm/slab.c:3229:54: error: 'PF_SPREAD_SLAB' undeclared (first use in this function)
if (current->mempolicy || unlikely(current->flags & PF_SPREAD_SLAB)) {
^
include/linux/compiler.h:131:45: note: in definition of macro 'unlikely'
# define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
^
mm/slab.c:3229:54: note: each undeclared identifier is reported only once for each function it ap
+pears in
if (current->mempolicy || unlikely(current->flags & PF_SPREAD_SLAB)) {
^
include/linux/compiler.h:131:45: note: in definition of macro 'unlikely'
# define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
^
vim +/PF_SPREAD_SLAB +3229 mm/slab.c
8c8cc2c1 Pekka Enberg 2007-02-10 3223
8c8cc2c1 Pekka Enberg 2007-02-10 3224 static __always_inline void *
8c8cc2c1 Pekka Enberg 2007-02-10 3225 __do_cache_alloc(struct kmem_cache *cache, gfp_t flags)
8c8cc2c1 Pekka Enberg 2007-02-10 3226 {
8c8cc2c1 Pekka Enberg 2007-02-10 3227 void *objp;
8c8cc2c1 Pekka Enberg 2007-02-10 3228
f0432d15 David Rientjes 2014-04-07 @3229 if (current->mempolicy || unlikely(current->flags &
+PF_SPREAD_SLAB)) {
8c8cc2c1 Pekka Enberg 2007-02-10 3230 objp = alternate_node_alloc(cache, flags);
8c8cc2c1 Pekka Enberg 2007-02-10 3231 if (objp)
8c8cc2c1 Pekka Enberg 2007-02-10 3232 goto out;
--
tejun
next prev parent reply other threads:[~2014-09-24 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 7:44 Zefan Li
2014-09-23 7:44 ` [PATCH v3 2/3] sched: add macros to define bitops for task atomic flags Zefan Li
2014-09-23 10:01 ` Peter Zijlstra
2014-09-23 16:58 ` Kees Cook
2014-09-23 7:45 ` [PATCH v3 3/3] cpuset: PF_SPREAD_PAGE and PF_SPREAD_SLAB should be " Zefan Li
2014-09-23 22:10 ` David Rientjes
2014-09-24 3:15 ` Zefan Li
2014-09-24 13:22 ` [PATCH v3 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant Tejun Heo
2014-09-24 13:35 ` Tejun Heo
2014-09-24 14:09 ` Tetsuo Handa
2014-09-24 14:32 ` Tejun Heo [this message]
2014-09-25 1:42 ` Zefan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924143247.GF16555@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=miaox@cn.fujitsu.com \
--cc=mingo@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®