From: Mika Westerberg <mika.westerberg@intel.com>
To: Loic Poulain <loic.poulain@intel.com>
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
samuel.ortiz@intel.com, mathias.nyman@linux.intel.com,
heikki.krogerus@linux.intel.com
Subject: Re: [PATCHv3] pinctrl: baytrail: Clear DIRECT_IRQ bit
Date: Mon, 29 Sep 2014 10:27:52 +0300 [thread overview]
Message-ID: <20140929072752.GD1786@lahna.fi.intel.com> (raw)
In-Reply-To: <1411740891-3311-1-git-send-email-loic.poulain@intel.com>
On Fri, Sep 26, 2014 at 04:14:51PM +0200, Loic Poulain wrote:
> Direct irq en bit should be cleared for pads using io mode.
> If not, the io based irq will never be detected.
> However, this bit can sometimes be misconfigured (BIOS issue).
> Force clearing of this bit in io mode and trigger a WARN.
>
> Signed-off-by: Loic Poulain <loic.poulain@intel.com>
That's more like it,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks!
next prev parent reply other threads:[~2014-09-29 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:14 Loic Poulain
2014-09-29 7:27 ` Mika Westerberg [this message]
2014-10-15 9:01 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929072752.GD1786@lahna.fi.intel.com \
--to=mika.westerberg@intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=samuel.ortiz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome