From: Christoph Hellwig <hch@infradead.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Nicolas Pitre <nico@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Nicholas Mc Guire <der.herr@hofr.at>
Subject: Re: aesbs-core.S_shipped?
Date: Wed, 1 Oct 2014 05:48:25 -0700 [thread overview]
Message-ID: <20141001124825.GA31067@infradead.org> (raw)
In-Reply-To: <CAKv+Gu-+FZ=mYc7pMWuFTboPpXN+a8Xj+NO7kqo_xVbZzQJwJw@mail.gmail.com>
On Tue, Sep 30, 2014 at 06:26:19PM +0200, Ard Biesheuvel wrote:
> > can you explain me why arch/arm/crypto/aesbs-core.S_shipped
> > is a _shipped file? I can't find any reason why it should be,
> > it's a normal .S file in every way as far as I can tell.
>
> It is generated by aesbs-core.pl, and Russell preferred including it
> as a _shipped file rather than generating it from the perl script on
> each build. (Note that the Perl script is kept in sync with OpenSSL,
> i.e., the goal is to be able to generate the kernel .S and the OpenSSL
> userland .S from the same script)
Thanks for the explanation. Can you update the script so that it
inserts a comment explaining how the file was generated into it?
Also to satisfy the GPL you need to include a copy of aesbs-core.pl in
the kernel tree. I only did a quick find -name aesbs-core.pl that
didn't find any results, so if it's named slightly differently feel
free to discard this second comment.
next prev parent reply other threads:[~2014-10-01 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 15:50 aesbs-core.S_shipped? Christoph Hellwig
2014-09-30 16:26 ` aesbs-core.S_shipped? Ard Biesheuvel
2014-10-01 12:48 ` Christoph Hellwig [this message]
2014-10-06 9:33 ` aesbs-core.S_shipped? Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001124825.GA31067@infradead.org \
--to=hch@infradead.org \
--cc=ard.biesheuvel@linaro.org \
--cc=der.herr@hofr.at \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®