From: Borislav Petkov <bp@alien8.de>
To: Matt Fleming <matt@console-pimps.org>
Cc: Mathias Krause <minipli@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCHv2 1/3] x86, ptdump: Add section for EFI runtime services
Date: Tue, 7 Oct 2014 17:01:32 +0200 [thread overview]
Message-ID: <20141007150132.GA7307@nazgul.tnic> (raw)
In-Reply-To: <20141003134707.GJ14343@console-pimps.org>
On Fri, Oct 03, 2014 at 02:47:07PM +0100, Matt Fleming wrote:
> Looks OK to me. Borislav?
It needs more work AFAICT because with it, espfix area gets cut off
prematurely:
...
[ 0.134611] ---[ Vmemmap ]---
[ 0.135003] 0xffffea0000000000-0xffffea0002000000 32M RW PSE GLB NX pmd
[ 0.136743] 0xffffea0002000000-0xffffea0040000000 992M pmd
[ 0.138091] 0xffffea0040000000-0xffffea8000000000 511G pud
[ 0.139611] 0xffffea8000000000-0xffffff0000000000 20992G pgd
[ 0.140610] ---[ ESPfix Area ]---
[ 0.141003] 0xffffff0000000000-0xffffff8000000000 512G pgd
[ 0.142614] 0xffffff8000000000-0xffffffef00000000 444G pud
[ 0.144088] ---[ EFI Runtime Services ]---
[ 0.144722] 0xffffffef00000000-0xfffffffec0000000 63G pud
[ 0.146090] 0xfffffffec0000000-0xfffffffefbe00000 958M pmd
[ 0.147613] 0xfffffffefbe00000-0xfffffffefbfe0000 1920K pte
[ 0.149003] 0xfffffffefbfe0000-0xfffffffefc000000 128K RW x pte
[ 0.150484] 0xfffffffefc000000-0xfffffffefc065000 404K pte
[ 0.151612] 0xfffffffefc065000-0xfffffffefc200000 1644K RW x pte
[ 0.153285] 0xfffffffefc200000-0xfffffffefc400000 2M RW PSE x pmd
[ 0.154721] 0xfffffffefc400000-0xfffffffefc5e0000 1920K RW x pte
...
and I think we want to see something more from the espfix area (this is
what we have now):
[ 0.138086] ---[ ESPfix Area ]---
[ 0.138590] 0xffffff0000000000-0xffffff8000000000 512G pgd
[ 0.140099] 0xffffff8000000000-0xfffffffec0000000 507G pud
[ 0.141444] 0xfffffffec0000000-0xfffffffefbe00000 958M pmd
[ 0.142597] 0xfffffffefbe00000-0xfffffffefbfe0000 1920K pte
[ 0.144086] 0xfffffffefbfe0000-0xfffffffefc000000 128K RW x pte
[ 0.145545] 0xfffffffefc000000-0xfffffffefc065000 404K pte
[ 0.146597] 0xfffffffefc065000-0xfffffffefc200000 1644K RW x pte
[ 0.148346] 0xfffffffefc200000-0xfffffffefc400000 2M RW PSE x pmd
[ 0.149776] 0xfffffffefc400000-0xfffffffefc5e0000 1920K RW x pte
[ 0.151347] 0xfffffffefc5e0000-0xfffffffefc631000 324K pte
[ 0.152593] 0xfffffffefc631000-0xfffffffefc655000 144K RW x pte
[ 0.154143] 0xfffffffefc655000-0xfffffffefc801000 1712K pte
[ 0.155437] 0xfffffffefc801000-0xfffffffefc831000 192K RW x pte
[ 0.157004] 0xfffffffefc831000-0xfffffffefc881000 320K pte
[ 0.158088] 0xfffffffefc881000-0xfffffffefca01000 1536K RW x pte
[ 0.159712] 0xfffffffefca01000-0xfffffffefcb34000 1228K pte
[ 0.161117] ... 36 entries skipped ...
But yeah, this issue needs to be addressed one way or the other as the
espfix dump skips the runtime services.
And frankly, I don't see where we're setting that ->max_lines thing but
it sounds like a promising thing to use. :)
Thanks.
--
Regards/Gruss,
Boris.
--
next prev parent reply other threads:[~2014-10-07 15:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 15:26 [PATCHv2 0/3] x86, ptdump: a EFI related fix + enhancements Mathias Krause
2014-09-21 15:26 ` [PATCHv2 1/3] x86, ptdump: Add section for EFI runtime services Mathias Krause
2014-10-03 13:47 ` Matt Fleming
2014-10-07 15:01 ` Borislav Petkov [this message]
2014-10-07 17:07 ` Mathias Krause
2014-10-08 15:17 ` Borislav Petkov
2014-10-08 21:58 ` Mathias Krause
2014-10-08 22:26 ` Borislav Petkov
2014-10-12 12:55 ` Mathias Krause
2014-10-28 18:57 ` Borislav Petkov
2014-10-28 19:48 ` Mathias Krause
2014-10-28 20:13 ` Borislav Petkov
2014-10-28 21:14 ` Mathias Krause
2014-10-28 21:26 ` Borislav Petkov
2014-10-28 21:49 ` Mathias Krause
2014-10-28 22:07 ` Borislav Petkov
2014-10-29 8:06 ` Mathias Krause
2014-10-29 14:20 ` Matt Fleming
2014-10-29 15:19 ` Mathias Krause
2014-10-29 14:22 ` Matt Fleming
2014-10-29 15:22 ` Mathias Krause
2014-11-11 21:59 ` Mathias Krause
2014-11-11 22:32 ` Matt Fleming
2014-09-21 15:26 ` [PATCHv2 2/3] x86, ptdump: Simplify page flag evaluation code Mathias Krause
2014-09-21 19:49 ` Arjan van de Ven
2014-09-21 20:33 ` Mathias Krause
2014-09-24 7:45 ` Ingo Molnar
2014-09-25 19:27 ` Mathias Krause
2014-09-26 9:25 ` Ingo Molnar
2014-09-26 10:11 ` Borislav Petkov
2014-09-26 11:15 ` Ingo Molnar
2014-09-26 12:35 ` Mathias Krause
2014-09-21 15:26 ` [PATCHv2 3/3] x86, ptdump: Take parent page flags into account Mathias Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007150132.GA7307@nazgul.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome