mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	gamerh2o@gmail.com, mark.einon@gmail.com
Subject: Re: [PATCH] staging: bcm: remove unnecessary else statement
Date: Wed, 8 Oct 2014 15:40:23 -0700	[thread overview]
Message-ID: <20141008224023.GB9464@kroah.com> (raw)
In-Reply-To: <1412099940-4118-1-git-send-email-karthik.188@gmail.com>

On Tue, Sep 30, 2014 at 11:29:00PM +0530, Karthik Nayak wrote:
> Removed the else statement occurring after an if statement with a
> return value as per checkpatch warning.
> 
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
>  drivers/staging/bcm/InterfaceMisc.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c
> index e5bcfec..1f31b8f 100644
> --- a/drivers/staging/bcm/InterfaceMisc.c
> +++ b/drivers/staging/bcm/InterfaceMisc.c
> @@ -102,12 +102,11 @@ int InterfaceWRM(struct bcm_interface_adapter *psIntfAdapter,
>  				DBG_LVL_ALL, "WRM failed status :%d", retval);
>  		psIntfAdapter->psAdapter->DeviceAccess = false;
>  		return retval;
> -	} else {
> -		psIntfAdapter->psAdapter->DeviceAccess = false;
> -		BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
> -				DBG_LVL_ALL, "WRM sent %d", retval);
> -		return STATUS_SUCCESS;
>  	}
> +	psIntfAdapter->psAdapter->DeviceAccess = false;
> +	BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
> +			DBG_LVL_ALL, "WRM sent %d", retval);
> +	return STATUS_SUCCESS;
>  }
>  
>  int BcmRDM(void *arg,
> -- 
> 2.1.0

This doesn't apply either, someone else must have done this change
already.

      reply	other threads:[~2014-10-08 22:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 17:59 Karthik Nayak
2014-10-08 22:40 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141008224023.GB9464@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gamerh2o@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.einon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®