* [PATCH] staging: bcm: remove unnecessary else statement
@ 2014-09-30 17:59 Karthik Nayak
2014-10-08 22:40 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Karthik Nayak @ 2014-09-30 17:59 UTC (permalink / raw)
To: linux-kernel; +Cc: devel, gamerh2o, gregkh, mark.einon, Karthik Nayak
Removed the else statement occurring after an if statement with a
return value as per checkpatch warning.
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
drivers/staging/bcm/InterfaceMisc.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c
index e5bcfec..1f31b8f 100644
--- a/drivers/staging/bcm/InterfaceMisc.c
+++ b/drivers/staging/bcm/InterfaceMisc.c
@@ -102,12 +102,11 @@ int InterfaceWRM(struct bcm_interface_adapter *psIntfAdapter,
DBG_LVL_ALL, "WRM failed status :%d", retval);
psIntfAdapter->psAdapter->DeviceAccess = false;
return retval;
- } else {
- psIntfAdapter->psAdapter->DeviceAccess = false;
- BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
- DBG_LVL_ALL, "WRM sent %d", retval);
- return STATUS_SUCCESS;
}
+ psIntfAdapter->psAdapter->DeviceAccess = false;
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
+ DBG_LVL_ALL, "WRM sent %d", retval);
+ return STATUS_SUCCESS;
}
int BcmRDM(void *arg,
--
2.1.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: bcm: remove unnecessary else statement
2014-09-30 17:59 [PATCH] staging: bcm: remove unnecessary else statement Karthik Nayak
@ 2014-10-08 22:40 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-10-08 22:40 UTC (permalink / raw)
To: Karthik Nayak; +Cc: linux-kernel, devel, gamerh2o, mark.einon
On Tue, Sep 30, 2014 at 11:29:00PM +0530, Karthik Nayak wrote:
> Removed the else statement occurring after an if statement with a
> return value as per checkpatch warning.
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
> drivers/staging/bcm/InterfaceMisc.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c
> index e5bcfec..1f31b8f 100644
> --- a/drivers/staging/bcm/InterfaceMisc.c
> +++ b/drivers/staging/bcm/InterfaceMisc.c
> @@ -102,12 +102,11 @@ int InterfaceWRM(struct bcm_interface_adapter *psIntfAdapter,
> DBG_LVL_ALL, "WRM failed status :%d", retval);
> psIntfAdapter->psAdapter->DeviceAccess = false;
> return retval;
> - } else {
> - psIntfAdapter->psAdapter->DeviceAccess = false;
> - BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
> - DBG_LVL_ALL, "WRM sent %d", retval);
> - return STATUS_SUCCESS;
> }
> + psIntfAdapter->psAdapter->DeviceAccess = false;
> + BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
> + DBG_LVL_ALL, "WRM sent %d", retval);
> + return STATUS_SUCCESS;
> }
>
> int BcmRDM(void *arg,
> --
> 2.1.0
This doesn't apply either, someone else must have done this change
already.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-08 22:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-30 17:59 [PATCH] staging: bcm: remove unnecessary else statement Karthik Nayak
2014-10-08 22:40 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®