From: Guenter Roeck <linux@roeck-us.net>
To: Carlo Caione <carlo@caione.org>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org, b.galvani@gmail.com
Subject: Re: [PATCH] ARM: meson: watchdog: remove magic value for reboot
Date: Thu, 9 Oct 2014 13:14:31 -0700 [thread overview]
Message-ID: <20141009201431.GA23397@roeck-us.net> (raw)
In-Reply-To: <1412884756-20943-1-git-send-email-carlo@caione.org>
On Thu, Oct 09, 2014 at 09:59:16PM +0200, Carlo Caione wrote:
> This patch removes the magic value used for rebooting the board. This
> value is useless and leads to a static checker warning as reported by
> Dan Carpenter.
>
> Signed-off-by: Carlo Caione <carlo@caione.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/meson_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/meson_wdt.c b/drivers/watchdog/meson_wdt.c
> index 37f9f5ec..ef6a298 100644
> --- a/drivers/watchdog/meson_wdt.c
> +++ b/drivers/watchdog/meson_wdt.c
> @@ -51,7 +51,7 @@ struct meson_wdt_dev {
> static int meson_restart_handle(struct notifier_block *this, unsigned long mode,
> void *cmd)
> {
> - u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN | 100;
> + u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN;
> struct meson_wdt_dev *meson_wdt = container_of(this,
> struct meson_wdt_dev,
> restart_handler);
> --
> 1.9.1
>
prev parent reply other threads:[~2014-10-09 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 19:59 Carlo Caione
2014-10-09 20:14 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009201431.GA23397@roeck-us.net \
--to=linux@roeck-us.net \
--cc=b.galvani@gmail.com \
--cc=carlo@caione.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome