* [PATCH] ARM: meson: watchdog: remove magic value for reboot
@ 2014-10-09 19:59 Carlo Caione
2014-10-09 20:14 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Carlo Caione @ 2014-10-09 19:59 UTC (permalink / raw)
To: wim, linux-watchdog, linux-kernel, linux, b.galvani; +Cc: Carlo Caione
This patch removes the magic value used for rebooting the board. This
value is useless and leads to a static checker warning as reported by
Dan Carpenter.
Signed-off-by: Carlo Caione <carlo@caione.org>
---
drivers/watchdog/meson_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/meson_wdt.c b/drivers/watchdog/meson_wdt.c
index 37f9f5ec..ef6a298 100644
--- a/drivers/watchdog/meson_wdt.c
+++ b/drivers/watchdog/meson_wdt.c
@@ -51,7 +51,7 @@ struct meson_wdt_dev {
static int meson_restart_handle(struct notifier_block *this, unsigned long mode,
void *cmd)
{
- u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN | 100;
+ u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN;
struct meson_wdt_dev *meson_wdt = container_of(this,
struct meson_wdt_dev,
restart_handler);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: meson: watchdog: remove magic value for reboot
2014-10-09 19:59 [PATCH] ARM: meson: watchdog: remove magic value for reboot Carlo Caione
@ 2014-10-09 20:14 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2014-10-09 20:14 UTC (permalink / raw)
To: Carlo Caione; +Cc: wim, linux-watchdog, linux-kernel, b.galvani
On Thu, Oct 09, 2014 at 09:59:16PM +0200, Carlo Caione wrote:
> This patch removes the magic value used for rebooting the board. This
> value is useless and leads to a static checker warning as reported by
> Dan Carpenter.
>
> Signed-off-by: Carlo Caione <carlo@caione.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/meson_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/meson_wdt.c b/drivers/watchdog/meson_wdt.c
> index 37f9f5ec..ef6a298 100644
> --- a/drivers/watchdog/meson_wdt.c
> +++ b/drivers/watchdog/meson_wdt.c
> @@ -51,7 +51,7 @@ struct meson_wdt_dev {
> static int meson_restart_handle(struct notifier_block *this, unsigned long mode,
> void *cmd)
> {
> - u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN | 100;
> + u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN;
> struct meson_wdt_dev *meson_wdt = container_of(this,
> struct meson_wdt_dev,
> restart_handler);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-09 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-09 19:59 [PATCH] ARM: meson: watchdog: remove magic value for reboot Carlo Caione
2014-10-09 20:14 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome