From: Paul Martin <pm@debian.org>
To: Nix <nix@esperi.org.uk>
Cc: Oliver Neukum <oliver@neukum.org>,
Johan Hovold <jhovold@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Daniel Silverstone <dsilvers@debian.org>
Subject: Re: [3.16.1 BISECTED REGRESSION]: Simtec Entropy Key (cdc-acm) broken in 3.16
Date: Sun, 12 Oct 2014 12:14:05 +0100 [thread overview]
Message-ID: <20141012111405.GB8275@thinkpad.nowster.org.uk> (raw)
In-Reply-To: <87y4smz1l0.fsf@spindle.srvr.nix>
On Sat, Oct 11, 2014 at 11:24:59PM +0100, Nix wrote:
> On 11 Oct 2014, Paul Martin spake thusly:
>
> > Having been privy to the firmware of the eKey, it is very simplistic,
> > with no implementation whatsoever of any flow control.
>
> That's what I thought. (Why would something that just provides data at a
> constant rate way below that of even the slowest USB bus *need* flow
> control?)
>
> One presumes therefore that the kernel suddenly trying to do flow
> control on shutdown would fubar the firmware's internal state, leading
> to the symptoms I see.
>
> So, the question becomes, is there a way to spot this general 'no flow
> control on this device' thing from the kernel side, or do we need a
> blacklist? Or, perhaps, if this is commonplace for cdc-acm devices, a
> whitelist? I can't imagine it's *that* commonplace or someone would have
> spotted this already in the months and months it took me to do the
> bisection.
>
> Maybe all non-modem cdc-acm devices should eschew flow control, or
> something? (This is a genuine guess and is almost certainly wrong.)
>
I'm going to pass this on to Daniel Silverstone, who did the actual
coding of the firmware.
--
Paul Martin <pm@debian.org>
next prev parent reply other threads:[~2014-10-12 11:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 23:07 [3.16.1 " Nix
2014-09-01 11:09 ` Oliver Neukum
2014-09-04 23:40 ` Nix
2014-09-05 7:59 ` Oliver Neukum
2014-09-05 15:17 ` Nix
2014-09-08 7:21 ` Oliver Neukum
2014-09-08 7:58 ` Nix
2014-10-11 19:05 ` [3.16.1 BISECTED " Nix
2014-10-11 19:51 ` Paul Martin
2014-10-11 22:24 ` Nix
2014-10-12 11:14 ` Paul Martin [this message]
2014-10-12 18:58 ` Johan Hovold
2014-10-12 21:36 ` Nix
2014-10-14 8:34 ` Johan Hovold
2014-10-14 14:44 ` Nix
2014-10-17 13:21 ` Nix
2014-10-19 13:45 ` Johan Hovold
2014-10-22 9:31 ` Nix
2014-10-22 10:14 ` Johan Hovold
2014-10-22 14:00 ` Nix
2014-10-22 15:36 ` Nix
2014-10-24 11:14 ` Johan Hovold
2014-10-24 15:08 ` Nix
2014-10-31 16:44 ` Nix
2014-11-05 11:56 ` Johan Hovold
2014-11-05 15:14 ` Nix
2014-11-05 15:46 ` Daniel Silverstone
2014-11-05 18:14 ` Johan Hovold
2014-11-06 13:49 ` Nix
2014-11-06 17:04 ` Johan Hovold
2014-11-06 17:08 ` [PATCH] USB: cdc-acm: add quirk for control-line state requests Johan Hovold
2014-11-07 9:05 ` Oliver Neukum
2014-11-07 9:16 ` Johan Hovold
2014-11-07 10:23 ` Oliver Neukum
2014-11-06 17:14 ` [3.16.1 BISECTED REGRESSION]: Simtec Entropy Key (cdc-acm) broken in 3.16 Nix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141012111405.GB8275@thinkpad.nowster.org.uk \
--to=pm@debian.org \
--cc=dsilvers@debian.org \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nix@esperi.org.uk \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®