* [PATCH] regulator: Include err.h from consumer.h to fix build failure
@ 2014-10-09 19:43 Guenter Roeck
2014-10-13 11:06 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2014-10-09 19:43 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown; +Cc: linux-kernel, Guenter Roeck
sh:sh2007_defconfig fails to build with the following error:
In file included from include/linux/regulator/machine.h:18:0,
from arch/sh/boards/board-sh2007.c:10:
include/linux/regulator/consumer.h: In function 'regulator_get_optional':
include/linux/regulator/consumer.h:271:2:
error: implicit declaration of function 'ERR_PTR'
include/linux/err.h: At top level:
include/linux/err.h:23:35: error: conflicting types for 'ERR_PTR'
include/linux/regulator/consumer.h:271:9:
note: previous implicit declaration of 'ERR_PTR' was here
Since consumer.h uses ERR_PTR, it should include err.h.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
include/linux/regulator/consumer.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h
index d347c80..f540b14 100644
--- a/include/linux/regulator/consumer.h
+++ b/include/linux/regulator/consumer.h
@@ -35,6 +35,8 @@
#ifndef __LINUX_REGULATOR_CONSUMER_H_
#define __LINUX_REGULATOR_CONSUMER_H_
+#include <linux/err.h>
+
struct device;
struct notifier_block;
struct regmap;
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: Include err.h from consumer.h to fix build failure
2014-10-09 19:43 [PATCH] regulator: Include err.h from consumer.h to fix build failure Guenter Roeck
@ 2014-10-13 11:06 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-10-13 11:06 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 276 bytes --]
On Thu, Oct 09, 2014 at 12:43:27PM -0700, Guenter Roeck wrote:
> sh:sh2007_defconfig fails to build with the following error:
>
> In file included from include/linux/regulator/machine.h:18:0,
> from arch/sh/boards/board-sh2007.c:10:
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-13 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-09 19:43 [PATCH] regulator: Include err.h from consumer.h to fix build failure Guenter Roeck
2014-10-13 11:06 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®