From: Andrew Morton <akpm@linux-foundation.org>
To: Hyogi Gim <ciogenis@gmail.com>
Cc: a.zummo@towertech.it, john.stultz@linaro.org,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/rtc/interface.c: check the validation of rtc_time in __rtc_read_time
Date: Tue, 14 Oct 2014 15:21:31 -0700 [thread overview]
Message-ID: <20141014152131.1442b937e3010a558c7798a6@linux-foundation.org> (raw)
In-Reply-To: <20141008020529.GA21464@lge.com>
On Wed, 8 Oct 2014 11:05:29 +0900 Hyogi Gim <ciogenis@gmail.com> wrote:
> Some of rtc devices always return '0' when rtc_class_ops.read_time is called.
> So if rtc_time isn't verified in callback, rtc interface cannot know whether
> rtc_time is valid.
We should fix the buggy .read_time() implementations...
> Check rtc_time by using 'rtc_valid_tm' in '__rtc_read_time'. And add the
> message for debugging.
>
next prev parent reply other threads:[~2014-10-14 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 2:05 Hyogi Gim
2014-10-14 22:21 ` Andrew Morton [this message]
2014-11-21 2:10 ` Hyogi Gim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014152131.1442b937e3010a558c7798a6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=ciogenis@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®