From: Hyogi Gim <ciogenis@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: a.zummo@towertech.it, john.stultz@linaro.org,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/rtc/interface.c: check the validation of rtc_time in __rtc_read_time
Date: Fri, 21 Nov 2014 11:10:39 +0900 [thread overview]
Message-ID: <20141121021039.GB8368@lge.com> (raw)
In-Reply-To: <20141014152131.1442b937e3010a558c7798a6@linux-foundation.org>
On Tue, Oct 14, 2014 at 03:21:31PM -0700, Andrew Morton wrote:
> On Wed, 8 Oct 2014 11:05:29 +0900 Hyogi Gim <ciogenis@gmail.com> wrote:
>
> > Some of rtc devices always return '0' when rtc_class_ops.read_time is called.
> > So if rtc_time isn't verified in callback, rtc interface cannot know whether
> > rtc_time is valid.
>
> We should fix the buggy .read_time() implementations...
>
Thanks for comments.
I'm studying rtc framework and trying to find a problem.
This is a minor bug. But, as you know, it can be a big problem for
newbies like me.
Even though it was late, I send you reply because a question.
If this patch is merged, rtc_valid_tm() in rtc_class_ops.read_time
callback is not necessary anymore.
So, I think each rtc device driver should change the code.
I can change the code. But, test is a little different.
In this case, how can I progress this modification?
Can I just send the notification for rtc_valid_tm() to the driver
manufacturer? or, request test for the code that I've modified?
--
Hyogi
prev parent reply other threads:[~2014-11-21 2:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 2:05 Hyogi Gim
2014-10-14 22:21 ` Andrew Morton
2014-11-21 2:10 ` Hyogi Gim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121021039.GB8368@lge.com \
--to=ciogenis@gmail.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®