From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: gregkh@linuxfoundation.org,
Fabio Estevam <fabio.estevam@freescale.com>,
linux-kernel@vger.kernel.org, mail@beyermatthias.de,
devel@driverdev.osuosl.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings
Date: Wed, 15 Oct 2014 22:55:49 +0300 [thread overview]
Message-ID: <20141015195549.GR26918@mwanda> (raw)
In-Reply-To: <1413399701-4321-1-git-send-email-jeffrey.t.kirsher@intel.com>
On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> The Beceem WIMAX was generating compile warnings on 64bit machines,
> which were:
>
> drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> (struct bcm_connect_mgr_params *) ntohl(
> ^
> drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> (struct bcm_connect_mgr_params *) ntohl(
> ^
> drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> (struct bcm_connect_mgr_params *) ntohl(
>
> This resolves the issue by preventing the driver to compile if CONFIG_64BIT
> is enabled, since the driver is known to be broken for 64 bit arch's.
>
Oops. Someone turned a Joe patch into a real patch. Please enable
COMPILE_TEST for this.
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-15 19:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 19:01 Jeff Kirsher
2014-10-15 19:55 ` Dan Carpenter [this message]
2014-10-15 20:26 ` Jeff Kirsher
2014-10-16 7:52 ` Dan Carpenter
2014-10-16 7:59 ` Jeff Kirsher
2014-10-16 8:09 ` Dan Carpenter
2014-10-15 22:59 ` Jeff Kirsher
2014-10-16 8:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015195549.GR26918@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@beyermatthias.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome