mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Joe Perches <joe@perches.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings
Date: Thu, 16 Oct 2014 10:13:07 +0200	[thread overview]
Message-ID: <20141016081307.GB9298@kroah.com> (raw)
In-Reply-To: <1413413961.2412.40.camel@jtkirshe-mobl>

On Wed, Oct 15, 2014 at 03:59:21PM -0700, Jeff Kirsher wrote:
> On Wed, 2014-10-15 at 12:01 -0700, Jeff Kirsher wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > The Beceem WIMAX was generating compile warnings on 64bit machines,
> > which were:
> > 
> > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >    (struct bcm_connect_mgr_params *) ntohl(
> >    ^
> > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >    (struct bcm_connect_mgr_params *) ntohl(
> >    ^
> > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >    (struct bcm_connect_mgr_params *) ntohl(
> > 
> > This resolves the issue by preventing the driver to compile if CONFIG_64BIT
> > is enabled, since the driver is known to be broken for 64 bit arch's.
> > 
> > CC: Dan Carpenter <dan.carpenter@oracle.com>
> > CC: Joe Perches <joe@perches.com>
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> 
> Greg- I have also submitted a patch to remove this driver entirely.  So
> if you choose to apply the patch to remove the driver, then you can
> disregard this patch.

Thanks, I'll take that removal patch now, I'm glad to get rid of that
mess.

greg k-h

      reply	other threads:[~2014-10-16  8:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15 19:01 Jeff Kirsher
2014-10-15 19:55 ` Dan Carpenter
2014-10-15 20:26   ` Jeff Kirsher
2014-10-16  7:52     ` Dan Carpenter
2014-10-16  7:59       ` Jeff Kirsher
2014-10-16  8:09         ` Dan Carpenter
2014-10-15 22:59 ` Jeff Kirsher
2014-10-16  8:13   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141016081307.GB9298@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fabio.estevam@freescale.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®