From: Andrew Morton <akpm@linux-foundation.org>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
mingo@kernel.org, Mark Rustad <mark.d.rustad@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/sysctl: Resolve missing-field-initializers warnings
Date: Tue, 21 Oct 2014 12:07:11 -0700 [thread overview]
Message-ID: <20141021120711.0ddb53adb4fdecf241826473@linux-foundation.org> (raw)
In-Reply-To: <87a94szydt.fsf@x220.int.ebiederm.org>
On Sat, 18 Oct 2014 17:39:10 -0700 ebiederm@xmission.com (Eric W. Biederman) wrote:
> Jeff Kirsher <jeffrey.t.kirsher@intel.com> writes:
>
> > From: Mark Rustad <mark.d.rustad@intel.com>
> >
> > Resolve missing-field-initializers warnings in W=2 builds by
> > using designated initialization.
>
> ick. No.
>
> That gcc warning makes no sense. In this case heeding it makes the code
> significantly uglier and significantly more confusing.
>
Yeah, it's not pretty.
> > --- a/kernel/sysctl.c
> > +++ b/kernel/sysctl.c
> > @@ -257,7 +257,7 @@ static struct ctl_table sysctl_base_table[] = {
> > .mode = 0555,
> > .child = dev_table,
> > },
> > - { }
> > + { .procname = NULL }
> > };
We use { } to mean "all zero" in 12 squillion places. Do they all warn
or is there something special about this site?
next prev parent reply other threads:[~2014-10-21 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 11:41 Jeff Kirsher
2014-10-19 0:39 ` Eric W. Biederman
2014-10-21 19:07 ` Andrew Morton [this message]
2014-10-21 20:34 ` Rustad, Mark D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021120711.0ddb53adb4fdecf241826473@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®