mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: akpm@linux-foundation.org, peterz@infradead.org,
	mingo@kernel.org, bp@suse.de, eranian@google.com,
	zheng.z.yan@intel.com, hpa@zytor.com, tglx@linutronix.de,
	josh@joshtriplett.org, linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore
Date: Tue, 28 Oct 2014 04:19:21 -0700	[thread overview]
Message-ID: <20141028111921.GB3274@tassilo.jf.intel.com> (raw)
In-Reply-To: <tip-7fb0f1de49fc75a0dcec22531f2d0a79fc2fb625@git.kernel.org>

> +config PERF_EVENTS_INTEL_UNCORE
> +	def_bool y

Why not give it a user name? It should be user configurable.

> +	depends on PERF_EVENTS && SUP_SUP_INTEL && PCI

SUP_SUP_INTEL looks wrong. Should be CPU_SUP_INTEL

I suspect you disabled it completely.

-Andi

       reply	other threads:[~2014-10-28 11:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tip-7fb0f1de49fc75a0dcec22531f2d0a79fc2fb625@git.kernel.org>
2014-10-28 11:19 ` Andi Kleen [this message]
2014-10-28 12:42   ` Peter Zijlstra
2014-10-28 12:48     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141028111921.GB3274@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=zheng.z.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®