From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: akpm@linux-foundation.org, mingo@kernel.org, bp@suse.de,
eranian@google.com, zheng.z.yan@intel.com, hpa@zytor.com,
tglx@linutronix.de, josh@joshtriplett.org,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore
Date: Tue, 28 Oct 2014 13:42:28 +0100 [thread overview]
Message-ID: <20141028124227.GR3337@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20141028111921.GB3274@tassilo.jf.intel.com>
On Tue, Oct 28, 2014 at 04:19:21AM -0700, Andi Kleen wrote:
> > +config PERF_EVENTS_INTEL_UNCORE
> > + def_bool y
>
> Why not give it a user name? It should be user configurable.
To avoid just that, another more or less pointless config option.
> > + depends on PERF_EVENTS && SUP_SUP_INTEL && PCI
>
> SUP_SUP_INTEL looks wrong. Should be CPU_SUP_INTEL
>
> I suspect you disabled it completely.
Indeed, typo there.
next prev parent reply other threads:[~2014-10-28 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-7fb0f1de49fc75a0dcec22531f2d0a79fc2fb625@git.kernel.org>
2014-10-28 11:19 ` Andi Kleen
2014-10-28 12:42 ` Peter Zijlstra [this message]
2014-10-28 12:48 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028124227.GR3337@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome