From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, tglx@linutronix.de, eranian@google.com,
dzickus@redhat.com, andi@firstfloor.org, jmario@redhat.com,
acme@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] perf,x86: De-obfuscate HSW offcore bits
Date: Tue, 28 Oct 2014 06:04:48 -0700 [thread overview]
Message-ID: <20141028130448.GH3274@tassilo.jf.intel.com> (raw)
In-Reply-To: <20141028123352.516276191@infradead.org>
On Tue, Oct 28, 2014 at 01:30:44PM +0100, Peter Zijlstra wrote:
> Andi introduced the HSW cache events array, but used magic constants
> against convention as set by all the other uarchs. Try and deobfuscate
> these a bit.
>
> The SDM doesn't appear to come close to actually describing the
> offcore but Andi said actual bit definitions were available from:
> https://download.01.org/perfmon/HSW/Haswell_matrix_bit_definitions_V14.json
>
> The below script was used to generate the macros.
I already have a script to generate. It can be extended to
generate the macros.
However again please test the events and only submit them if they
work. The tested bits I used are all documents in the previous
comments. Anything that differs now needs to be retested by you.
-Andi
next prev parent reply other threads:[~2014-10-28 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 12:30 [PATCH 0/3] Cleanup of the " Peter Zijlstra
2014-10-28 12:30 ` [PATCH 1/3] perf,x86: De-obfuscate " Peter Zijlstra
2014-10-28 13:04 ` Andi Kleen [this message]
2014-10-28 12:30 ` [PATCH 2/3] perf,x86: Sanitize HSW offcore events Peter Zijlstra
2014-10-28 12:30 ` [PATCH 3/3] perf,x86: Add HSW offcore NUMA events Peter Zijlstra
2014-10-28 13:10 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028130448.GH3274@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dzickus@redhat.com \
--cc=eranian@google.com \
--cc=jmario@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome