mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mikael Svantesson <mikael@distopic.net>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	devel@driverdev.osuosl.org, Jason Cooper <jason@lakedaemon.net>,
	linux-kernel@vger.kernel.org, Jake Edge <jake@lwn.net>,
	Anton Saraev <antonysaraev@gmail.com>
Subject: Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','
Date: Thu, 30 Oct 2014 00:05:53 +0800	[thread overview]
Message-ID: <20141029160553.GB18125@kroah.com> (raw)
In-Reply-To: <5450966A.20709@distopic.net>

On Wed, Oct 29, 2014 at 08:25:30AM +0100, Mikael Svantesson wrote:
> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> ---
>  drivers/staging/skein/skein_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> index 6e700ee..5bfce07 100644
> --- a/drivers/staging/skein/skein_api.c
> +++ b/drivers/staging/skein/skein_api.c
> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>  {
>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>  
> -	memset(ctx , 0, sizeof(struct skein_ctx));
> +	memset(ctx, 0, sizeof(struct skein_ctx));
>  	ctx->skein_size = size;
>  
>  	return SKEIN_SUCCESS;
> -- 
> 2.1.1
> 
> On 2014-10-29 08:15, Mikael Svantesson wrote:
> > I'm saving the patch to my mail server using git-imap-send, then enter
> > e-mail addresses using Thunderbird and send it.
> > 
> > The problem seems to be that Thunderbird thrashes empty lines when
> > double clicking the e-mail in Drafts or selecting "Edit as new".
> > When forwarding the e-mail it doesn't seem to affect the empty lines,
> > very weird behaviour.
> > 
> > Regards,
> > 
> > Mikael
> > 
> > On 2014-10-29 06:25, Sudip Mukherjee wrote:
> >> On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
> >>> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> >> still the same problem.
> >>
> >> ERROR: patch seems to be corrupt (line wrapped?)
> >>
> >>
> >>> ---
> >>>  drivers/staging/skein/skein_api.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> >>> index 6e700ee..5bfce07 100644
> >>> --- a/drivers/staging/skein/skein_api.c
> >>> +++ b/drivers/staging/skein/skein_api.c
> >>> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
> >>>  {
> >>>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
> >>>  -	memset(ctx , 0, sizeof(struct skein_ctx));
> >>> +	memset(ctx, 0, sizeof(struct skein_ctx));
> >>>  	ctx->skein_size = size;
> >>>   	return SKEIN_SUCCESS;
> >>> -- 
> >>> 2.1.1
> >>>
> >>> --
> >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >>> the body of a message to majordomo@vger.kernel.org
> >>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >>> Please read the FAQ at  http://www.tux.org/lkml/
> > 

Please send this as a "correct" patch, not one with a whole bunch of
other stuff in it that I would have to hand-edit in order to apply
properly.

Remember, you want to make it as easy as possible for me to accept your
patches, so far, this isn't going well :)

greg k-h

  reply	other threads:[~2014-10-29 16:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 20:07 Mikael Svantesson
2014-10-29  5:25 ` Sudip Mukherjee
2014-10-29  7:15   ` Mikael Svantesson
2014-10-29  7:25     ` Mikael Svantesson
2014-10-29 16:05       ` Greg Kroah-Hartman [this message]
2014-10-29 16:38         ` Mikael Svantesson
2014-10-29 17:45           ` [PATCH] " Mikael Svantesson
2014-10-30  5:45             ` Sudip Mukherjee
2014-10-29  8:06     ` [PATCH v2] " Sudip Mukherjee
2014-10-29  8:41 ` Greg Kroah-Hartman
2014-10-29 15:56   ` Mikael Svantesson
     [not found]     ` <1414601738-11968-1-git-send-email-mikael@distopic.net>
2014-10-29 17:51       ` [PATCH] " Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141029160553.GB18125@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=antonysaraev@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=jake@lwn.net \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikael@distopic.net \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®