mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikael Svantesson <mikael@distopic.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jason Cooper <jason@lakedaemon.net>, Jake Edge <jake@lwn.net>,
	Anton Saraev <antonysaraev@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	"mikael@distopic.net >> Mikael Svantesson" <mikael@distopic.net>
Subject: Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','
Date: Wed, 29 Oct 2014 16:56:15 +0100	[thread overview]
Message-ID: <54510E1F.3050801@distopic.net> (raw)
In-Reply-To: <20141029084118.GB5333@kroah.com>

On 2014-10-29 09:41, Greg Kroah-Hartman wrote:
> On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
>> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
>> ---
>>  drivers/staging/skein/skein_api.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
>> index 6e700ee..5bfce07 100644
>> --- a/drivers/staging/skein/skein_api.c
>> +++ b/drivers/staging/skein/skein_api.c
>> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>>  {
>>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>>  -	memset(ctx , 0, sizeof(struct skein_ctx));
>> +	memset(ctx, 0, sizeof(struct skein_ctx));
> 
> Still corrupted, what added the extra ' ' before the '-'?
> 
Thunderbird builtin editor, I guess. Can't remember why I decided to do
it that way instead of git-send-email.

I replied to my other explanation with a non-corrupt patch but I can
submit it as v3 instead if that's preferable.

/ Mikael

  reply	other threads:[~2014-10-29 15:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 20:07 Mikael Svantesson
2014-10-29  5:25 ` Sudip Mukherjee
2014-10-29  7:15   ` Mikael Svantesson
2014-10-29  7:25     ` Mikael Svantesson
2014-10-29 16:05       ` Greg Kroah-Hartman
2014-10-29 16:38         ` Mikael Svantesson
2014-10-29 17:45           ` [PATCH] " Mikael Svantesson
2014-10-30  5:45             ` Sudip Mukherjee
2014-10-29  8:06     ` [PATCH v2] " Sudip Mukherjee
2014-10-29  8:41 ` Greg Kroah-Hartman
2014-10-29 15:56   ` Mikael Svantesson [this message]
     [not found]     ` <1414601738-11968-1-git-send-email-mikael@distopic.net>
2014-10-29 17:51       ` [PATCH] " Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54510E1F.3050801@distopic.net \
    --to=mikael@distopic.net \
    --cc=antonysaraev@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jake@lwn.net \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome