mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: panel: Use designated initializers
@ 2014-10-29 22:32 Mariusz Gorski
  2014-10-30  6:13 ` Willy Tarreau
  0 siblings, 1 reply; 2+ messages in thread
From: Mariusz Gorski @ 2014-10-29 22:32 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Willy Tarreau; +Cc: devel, linux-kernel

Fix "warning: missing initializer [-Wmissing-field-initializers]"
by using designated struct initializers.

Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
---
 drivers/staging/panel/panel.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 6d1a320..98556ce 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1375,9 +1375,9 @@ static const struct file_operations lcd_fops = {
 };
 
 static struct miscdevice lcd_dev = {
-	LCD_MINOR,
-	"lcd",
-	&lcd_fops
+	.minor	= LCD_MINOR,
+	.name	= "lcd",
+	.fops	= &lcd_fops,
 };
 
 /* public function usable from the kernel for any purpose */
@@ -1652,9 +1652,9 @@ static const struct file_operations keypad_fops = {
 };
 
 static struct miscdevice keypad_dev = {
-	KEYPAD_MINOR,
-	"keypad",
-	&keypad_fops
+	.minor	= KEYPAD_MINOR,
+	.name	= "keypad",
+	.fops	= &keypad_fops,
 };
 
 static void keypad_send_key(const char *string, int max_len)
-- 
2.1.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: panel: Use designated initializers
  2014-10-29 22:32 [PATCH] staging: panel: Use designated initializers Mariusz Gorski
@ 2014-10-30  6:13 ` Willy Tarreau
  0 siblings, 0 replies; 2+ messages in thread
From: Willy Tarreau @ 2014-10-30  6:13 UTC (permalink / raw)
  To: Mariusz Gorski; +Cc: Greg Kroah-Hartman, devel, linux-kernel

Hi Mariusz,

On Wed, Oct 29, 2014 at 11:32:30PM +0100, Mariusz Gorski wrote:
> Fix "warning: missing initializer [-Wmissing-field-initializers]"
> by using designated struct initializers.
> 
> Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>

Acked-by: Willy Tarreau <w@1wt.eu>

Thanks,
Willy


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-30  6:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-29 22:32 [PATCH] staging: panel: Use designated initializers Mariusz Gorski
2014-10-30  6:13 ` Willy Tarreau

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®