From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Lower priorit of constraint logging
Date: Fri, 31 Oct 2014 12:34:09 -0700 [thread overview]
Message-ID: <20141031193409.GA11608@roeck-us.net> (raw)
In-Reply-To: <1414782761-15372-1-git-send-email-broonie@kernel.org>
On Fri, Oct 31, 2014 at 07:12:41PM +0000, Mark Brown wrote:
> Some systems have very large numbers of regulators so the constraint
> logging done at startup can end up being a very big part of the boot
> output which is both verobse and slows things down if the console is
s/verobse/verbose/
> a serial console. Lower to dev_dbg() instead, we may want to provide
> a boot parameter to raise this in future but for now people can edit
> the source.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
You might want to run 's/priorit/priority/' on the subject.
Otherwise
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/regulator/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 55a87a2722d8..bbf93c9caca3 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -828,7 +828,7 @@ static void print_constraints(struct regulator_dev *rdev)
> if (!count)
> sprintf(buf, "no parameters");
>
> - rdev_info(rdev, "%s\n", buf);
> + rdev_dbg(rdev, "%s\n", buf);
>
> if ((constraints->min_uV != constraints->max_uV) &&
> !(constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE))
> --
> 2.1.1
>
prev parent reply other threads:[~2014-10-31 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 19:12 Mark Brown
2014-10-31 19:34 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031193409.GA11608@roeck-us.net \
--to=linux@roeck-us.net \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome