mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] regulator: Lower priorit of constraint logging
@ 2014-10-31 19:12 Mark Brown
  2014-10-31 19:34 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2014-10-31 19:12 UTC (permalink / raw)
  To: Guenter Roeck, Liam Girdwood; +Cc: linux-kernel, Mark Brown

Some systems have very large numbers of regulators so the constraint
logging done at startup can end up being a very big part of the boot
output which is both verobse and slows things down if the console is
a serial console. Lower to dev_dbg() instead, we may want to provide
a boot parameter to raise this in future but for now people can edit
the source.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 55a87a2722d8..bbf93c9caca3 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -828,7 +828,7 @@ static void print_constraints(struct regulator_dev *rdev)
 	if (!count)
 		sprintf(buf, "no parameters");
 
-	rdev_info(rdev, "%s\n", buf);
+	rdev_dbg(rdev, "%s\n", buf);
 
 	if ((constraints->min_uV != constraints->max_uV) &&
 	    !(constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE))
-- 
2.1.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] regulator: Lower priorit of constraint logging
  2014-10-31 19:12 [PATCH] regulator: Lower priorit of constraint logging Mark Brown
@ 2014-10-31 19:34 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2014-10-31 19:34 UTC (permalink / raw)
  To: Mark Brown; +Cc: Liam Girdwood, linux-kernel

On Fri, Oct 31, 2014 at 07:12:41PM +0000, Mark Brown wrote:
> Some systems have very large numbers of regulators so the constraint
> logging done at startup can end up being a very big part of the boot
> output which is both verobse and slows things down if the console is

	s/verobse/verbose/

> a serial console. Lower to dev_dbg() instead, we may want to provide
> a boot parameter to raise this in future but for now people can edit
> the source.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

You might want to run 's/priorit/priority/' on the subject.

Otherwise

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/regulator/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 55a87a2722d8..bbf93c9caca3 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -828,7 +828,7 @@ static void print_constraints(struct regulator_dev *rdev)
>  	if (!count)
>  		sprintf(buf, "no parameters");
>  
> -	rdev_info(rdev, "%s\n", buf);
> +	rdev_dbg(rdev, "%s\n", buf);
>  
>  	if ((constraints->min_uV != constraints->max_uV) &&
>  	    !(constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE))
> -- 
> 2.1.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-31 19:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-31 19:12 [PATCH] regulator: Lower priorit of constraint logging Mark Brown
2014-10-31 19:34 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome