From: Peter Zijlstra <peterz@infradead.org>
To: Pawel Moll <pawel.moll@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Christopher Covington <cov@codeaurora.org>,
David Ahern <dsahern@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] perf: Userspace event
Date: Tue, 4 Nov 2014 19:40:31 +0100 [thread overview]
Message-ID: <20141104184031.GM10501@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1415119331.24819.19.camel@arm.com>
On Tue, Nov 04, 2014 at 04:42:11PM +0000, Pawel Moll wrote:
>
> 1. I'm wrong and the record doesn't have to be padded to make it 8 bytes
> aligned. Then I can drop the additional size field.
No, you're right, we're supposed to stay 8 byte aligned.
> 2. I could impose a limitation on the prctl API that the data size must
> be 8 bytes aligned. Bad idea in my opinion, I'd rather not.
Agreed.
> 3. The additional size (for the data part) field stays. Notice that
> PERF_SAMPLE_RAW has it as well :-)
Right, with binary data there is no other day. With \0 terminated
strings there won't be a problem, but I think we decided we wanted to
allow any binary blow.
next prev parent reply other threads:[~2014-11-04 18:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 0:28 [PATCH v3 0/3] perf: User/kernel time correlation and event generation Pawel Moll
2014-11-04 0:28 ` [PATCH v3 1/3] perf: Use monotonic clock as a source for timestamps Pawel Moll
2014-11-04 7:23 ` Peter Zijlstra
2014-11-04 15:25 ` Pawel Moll
2014-11-04 15:30 ` Peter Zijlstra
2014-11-04 0:28 ` [PATCH v3 2/3] perf: Userspace event Pawel Moll
2014-11-04 6:33 ` Namhyung Kim
2014-11-04 16:42 ` Pawel Moll
2014-11-04 18:40 ` Peter Zijlstra [this message]
2014-11-05 6:36 ` Namhyung Kim
2014-11-04 0:28 ` [PATCH v3 3/3] perf: Sample additional clock value Pawel Moll
2014-11-04 0:58 ` [PATCH v3 0/3] perf: User/kernel time correlation and event generation Andy Lutomirski
2014-11-04 1:11 ` John Stultz
2014-11-04 1:25 ` Andy Lutomirski
2014-11-04 15:07 ` Pawel Moll
2014-11-04 8:01 ` Arnd Bergmann
2014-11-04 8:27 ` Richard Cochran
2014-11-04 10:49 ` Thomas Gleixner
2014-11-04 16:11 ` Arnd Bergmann
2014-11-04 16:04 ` John Stultz
2014-11-04 8:24 ` Richard Cochran
2014-11-04 9:24 ` Masami Hiramatsu
2014-11-04 15:51 ` Pawel Moll
2014-11-05 8:06 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104184031.GM10501@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=cov@codeaurora.org \
--cc=dsahern@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=pawel.moll@arm.com \
--cc=richardcochran@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tomeu@tomeuvizoso.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome