mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Peter Zijlstra  <public-peterz-wEGCiKHe2LqWVfeAwA7xHQ@plane.gmane.org>
Cc: Pawel Moll <public-pawel.moll-5wv7dgnIgG8@plane.gmane.org>,
	Namhyung Kim 
	<public-namhyung-DgEjT+Ai2ygdnm+yROfE0A@plane.gmane.org>,
	Richard Cochran 
	<public-richardcochran-Re5JQEeQqe8AvxtiuMwx3w@plane.gmane.org>,
	Steven Rostedt 
	<public-rostedt-nx8X9YLhiw1AfugRpC6u6w@plane.gmane.org>,
	Ingo Molnar <public-mingo-H+wXaHxf7aLQT0dZR+AlfA@plane.gmane.org>,
	Paul Mackerras 
	<public-paulus-eUNUBHrolfbYtjvyW6yDsg@plane.gmane.org>,
	Arnaldo Carvalho de Melo 
	<public-acme-DgEjT+Ai2ygdnm+yROfE0A@plane.gmane.org>,
	John Stultz 
	<public-john.stultz-QSEj5FYQhm4dnm+yROfE0A@plane.gmane.org>,
	Masami Hiramatsu 
	<public-masami.hiramatsu.pt-FCd8Q96Dh0JBDgjK7y7TUQ@plane.gmane.org>,
	Christopher Covington 
	<public-cov-sgV2jX0FEOL9JmXXK+q4OQ@plane.gmane.org>,
	David Ahern 
	<public-dsahern-Re5JQEeQqe8AvxtiuMwx3w@plane.gmane.org>,
	Thomas Gleixner 
	<public-tglx-hfZtesqFncYOwBW4kG4KsQ@plane.gmane.org>,
	Tomeu Vizoso 
	<public-tomeu-XCtybt49RKsYaV1qd6yewg@plane.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA\@public.gmane.org" 
	<public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org>,
	"linux-api-u79uwXL29TY76Z2rM5mHXA\@public.gmane.org" 
	<public-linux-api-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org>
Subject: Re: [PATCH v3 2/3] perf: Userspace event
Date: Wed, 05 Nov 2014 15:36:31 +0900	[thread overview]
Message-ID: <878ujqw3v4.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20141104184031.GM10501@worktop.programming.kicks-ass.net> (Peter Zijlstra's message of "Tue, 4 Nov 2014 19:40:31 +0100")



Hi Peter and Pawel,

On Tue, 4 Nov 2014 19:40:31 +0100, Peter Zijlstra wrote:
> On Tue, Nov 04, 2014 at 04:42:11PM +0000, Pawel Moll wrote:
>> 
>> 1. I'm wrong and the record doesn't have to be padded to make it 8 bytes
>> aligned. Then I can drop the additional size field.
>
> No, you're right, we're supposed to stay 8 byte aligned.
>
>> 2. I could impose a limitation on the prctl API that the data size must
>> be 8 bytes aligned. Bad idea in my opinion, I'd rather not.
>
> Agreed.
>
>> 3. The additional size (for the data part) field stays. Notice that
>> PERF_SAMPLE_RAW has it as well :-)
>
> Right, with binary data there is no other day. With \0 terminated
> strings there won't be a problem, but I think we decided we wanted to
> allow any binary blow.

Ah, I missed that.  Thank you guys for explanation.

Thanks,
Namhyung


  reply	other threads:[~2014-11-05  6:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04  0:28 [PATCH v3 0/3] perf: User/kernel time correlation and event generation Pawel Moll
2014-11-04  0:28 ` [PATCH v3 1/3] perf: Use monotonic clock as a source for timestamps Pawel Moll
2014-11-04  7:23   ` Peter Zijlstra
2014-11-04 15:25     ` Pawel Moll
2014-11-04 15:30       ` Peter Zijlstra
2014-11-04  0:28 ` [PATCH v3 2/3] perf: Userspace event Pawel Moll
2014-11-04  6:33   ` Namhyung Kim
2014-11-04 16:42     ` Pawel Moll
2014-11-04 18:40       ` Peter Zijlstra
2014-11-05  6:36         ` Namhyung Kim [this message]
2014-11-04  0:28 ` [PATCH v3 3/3] perf: Sample additional clock value Pawel Moll
2014-11-04  0:58 ` [PATCH v3 0/3] perf: User/kernel time correlation and event generation Andy Lutomirski
2014-11-04  1:11   ` John Stultz
2014-11-04  1:25     ` Andy Lutomirski
2014-11-04 15:07       ` Pawel Moll
2014-11-04  8:01     ` Arnd Bergmann
2014-11-04  8:27       ` Richard Cochran
2014-11-04 10:49         ` Thomas Gleixner
2014-11-04 16:11           ` Arnd Bergmann
2014-11-04 16:04       ` John Stultz
2014-11-04  8:24     ` Richard Cochran
2014-11-04  9:24 ` Masami Hiramatsu
2014-11-04 15:51   ` Pawel Moll
2014-11-05  8:06     ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ujqw3v4.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=public-acme-DgEjT+Ai2ygdnm+yROfE0A@plane.gmane.org \
    --cc=public-cov-sgV2jX0FEOL9JmXXK+q4OQ@plane.gmane.org \
    --cc=public-dsahern-Re5JQEeQqe8AvxtiuMwx3w@plane.gmane.org \
    --cc=public-john.stultz-QSEj5FYQhm4dnm+yROfE0A@plane.gmane.org \
    --cc=public-linux-api-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org \
    --cc=public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org \
    --cc=public-masami.hiramatsu.pt-FCd8Q96Dh0JBDgjK7y7TUQ@plane.gmane.org \
    --cc=public-mingo-H+wXaHxf7aLQT0dZR+AlfA@plane.gmane.org \
    --cc=public-namhyung-DgEjT+Ai2ygdnm+yROfE0A@plane.gmane.org \
    --cc=public-paulus-eUNUBHrolfbYtjvyW6yDsg@plane.gmane.org \
    --cc=public-pawel.moll-5wv7dgnIgG8@plane.gmane.org \
    --cc=public-peterz-wEGCiKHe2LqWVfeAwA7xHQ@plane.gmane.org \
    --cc=public-richardcochran-Re5JQEeQqe8AvxtiuMwx3w@plane.gmane.org \
    --cc=public-rostedt-nx8X9YLhiw1AfugRpC6u6w@plane.gmane.org \
    --cc=public-tglx-hfZtesqFncYOwBW4kG4KsQ@plane.gmane.org \
    --cc=public-tomeu-XCtybt49RKsYaV1qd6yewg@plane.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome