From: Mark Brown <broonie@kernel.org>
To: NeilBrown <neilb@suse.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
GTA04 owners <gta04-owner@goldelico.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ASoC: twl4030: enable routing audio to 'voice' interface.
Date: Sat, 8 Nov 2014 09:27:56 +0000 [thread overview]
Message-ID: <20141108092756.GD2722@sirena.org.uk> (raw)
In-Reply-To: <20141108003803.6561.52497.stgit@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
On Sat, Nov 08, 2014 at 11:38:03AM +1100, NeilBrown wrote:
> - twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
> - TWL4030_VIF_TRI_EN,
> - TWL4030_REG_VOICE_IF);
> + /* These pins only relevant when voice_fmt set */
> + snd_soc_dapm_disable_pin(&codec->dapm, "VOICEIN");
> + snd_soc_dapm_disable_pin(&codec->dapm, "VOICEOUT");
Given your previous patch are these trying to control a digital link by
any chance? If they are they should be removed, and in any case this
sort of thing looks like a machine driver issue.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-08 9:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 0:38 [PATCH 0/3] ASoC: twl4030: support routine to external VOICE source NeilBrown
2014-11-08 0:38 ` [PATCH 3/3] ASoC: twl4030: enable routing audio to 'voice' interface NeilBrown
2014-11-08 9:27 ` Mark Brown [this message]
2014-11-09 23:54 ` NeilBrown
2014-11-10 10:48 ` Mark Brown
2014-11-08 0:38 ` [PATCH 2/3] ASoC: twl4030: allow voice port to be connected externally NeilBrown
2014-11-08 9:26 ` Mark Brown
2014-11-09 23:25 ` NeilBrown
2014-11-10 6:46 ` [Gta04-owner] " Dr. H. Nikolaus Schaller
2014-11-10 12:11 ` Mark Brown
2014-11-08 0:38 ` [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change requested NeilBrown
2014-11-08 9:22 ` Mark Brown
2014-11-10 0:45 ` NeilBrown
2014-11-10 7:07 ` [alsa-devel] " Lars-Peter Clausen
2014-11-10 21:45 ` NeilBrown
2014-11-10 21:49 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141108092756.GD2722@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=gta04-owner@goldelico.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=neilb@suse.de \
--cc=pawel.moll@arm.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome