From: Mark Brown <broonie@kernel.org>
To: NeilBrown <neilb@suse.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
GTA04 owners <gta04-owner@goldelico.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ASoC: twl4030: allow voice port to be connected externally.
Date: Mon, 10 Nov 2014 12:11:55 +0000 [thread overview]
Message-ID: <20141110121155.GN3815@sirena.org.uk> (raw)
In-Reply-To: <20141110102551.2678d342@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On Mon, Nov 10, 2014 at 10:25:51AM +1100, NeilBrown wrote:
> says it is a "reference platform". Does that mean it is a board with a bunch
> of chips soldered onto it? If it were a board it should be described by a
> dts file, not by a pile of C code (I thought), so I must be wrong about that.
No, like I say please see previous discussion ad nauseum about this.
> The twl4030 needs to know the master/polarity of the clk/frm lines. The GSM
> module declares that these are. So presumably we need some sort of linkage.
> Ahhhh... I found Documentation/devicetree/bindings/sound/simple-card.txt
Or just write a machine driver. simple-card is one such machine driver
but it's not going to be suitable for non-trivial systems. Possibly
your system is simple enough, possibly it isn't - I don't know anything
about it really. Regardless of how you do this it shouldn't have
individual devices needing to open code configuration for links, it's
something essentially every device is going to need to do and forcing
the DT to configure the same thing twice for a link isn't a good idea
either.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-11-10 12:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 0:38 [PATCH 0/3] ASoC: twl4030: support routine to external VOICE source NeilBrown
2014-11-08 0:38 ` [PATCH 3/3] ASoC: twl4030: enable routing audio to 'voice' interface NeilBrown
2014-11-08 9:27 ` Mark Brown
2014-11-09 23:54 ` NeilBrown
2014-11-10 10:48 ` Mark Brown
2014-11-08 0:38 ` [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change requested NeilBrown
2014-11-08 9:22 ` Mark Brown
2014-11-10 0:45 ` NeilBrown
2014-11-10 7:07 ` [alsa-devel] " Lars-Peter Clausen
2014-11-10 21:45 ` NeilBrown
2014-11-10 21:49 ` Lars-Peter Clausen
2014-11-08 0:38 ` [PATCH 2/3] ASoC: twl4030: allow voice port to be connected externally NeilBrown
2014-11-08 9:26 ` Mark Brown
2014-11-09 23:25 ` NeilBrown
2014-11-10 6:46 ` [Gta04-owner] " Dr. H. Nikolaus Schaller
2014-11-10 12:11 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110121155.GN3815@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=gta04-owner@goldelico.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=neilb@suse.de \
--cc=pawel.moll@arm.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®