[PATCH] regulator: tps65218: Remove '.owner' field

[PATCH] regulator: tps65218: Remove '.owner' field

[Manish Badarkhe]

Remove '.owner' field of driver structure as it is
going to be filled via "module_platform_driver" call.

Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
---
:100644 100644 f0a4028... e2b97ac... M	drivers/regulator/tps65218-regulator.c
 drivers/regulator/tps65218-regulator.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
index f0a4028..e2b97ac 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -255,7 +255,6 @@ static int tps65218_regulator_probe(struct platform_device *pdev)
 static struct platform_driver tps65218_regulator_driver = {
 	.driver = {
 		.name = "tps65218-pmic",
-		.owner = THIS_MODULE,
 		.of_match_table = tps65218_of_match,
 	},
 	.probe = tps65218_regulator_probe,
-- 
1.7.10.4

Re: [PATCH] regulator: tps65218: Remove '.owner' field

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

On Sat, Nov 08, 2014 at 05:42:52PM +0530, Manish Badarkhe wrote:
> Remove '.owner' field of driver structure as it is
> going to be filled via "module_platform_driver" call.

Same question as ever with this stuff: if we've decided to do this why
are we doing it for a single driver and not as a genric cleanup?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] regulator: tps65218: Remove '.owner' field

[Manish Badarkhe]

Hi Mark,

On Sun, Nov 9, 2014 at 2:49 PM, Mark Brown <broonie@kernel.org> wrote:
> On Sat, Nov 08, 2014 at 05:42:52PM +0530, Manish Badarkhe wrote:
>> Remove '.owner' field of driver structure as it is
>> going to be filled via "module_platform_driver" call.
>
> Same question as ever with this stuff: if we've decided to do this why
> are we doing it for a single driver and not as a genric cleanup?

There are many drivers needs to be changed with such fix.
Can we fix drivers with this fix module by module or all at once?
Please let me know your opinion.

Thanks
Manish Badarkhe

Re: [PATCH] regulator: tps65218: Remove '.owner' field

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

On Mon, Nov 10, 2014 at 07:49:16PM +0530, Manish Badarkhe wrote:
> On Sun, Nov 9, 2014 at 2:49 PM, Mark Brown <broonie@kernel.org> wrote:

> > Same question as ever with this stuff: if we've decided to do this why
> > are we doing it for a single driver and not as a genric cleanup?

> There are many drivers needs to be changed with such fix.
> Can we fix drivers with this fix module by module or all at once?
> Please let me know your opinion.

All at once, though I think Greg just did that in -next anyway.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]