Re: [PATCH v6 10/10] tpm: TPM 2.0 sysfs attributes

[Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>]

On Mon, Nov 10, 2014 at 11:03:05AM -0700, Jason Gunthorpe wrote:
> On Mon, Nov 10, 2014 at 02:49:54PM +0200, Jarkko Sakkinen wrote:
> 
> >  	if (len > le32_to_cpu(cca->cmd_size)) {
> > -		dev_err(chip->dev,
> > +		dev_err(&chip->dev,
> 
> Is this out of sequence in the patch series?

It is, must have rebased the fixup into wrong commit.

> >  	rc = tpm2_do_selftest(chip);
> > -	if (rc) {
> > -		dev_err(dev, "self-test failed\n");
> > +	if (rc)
> >  		return rc;
> > -	}
> >  
> >  	rc = tpm_chip_register(chip);
> > -	if (rc) {
> > -		dev_err(dev, "registering the chip failed\n");
> > +	if (rc)
> >  		return rc;
> > -	}
> 
> Ditto.
> 
> Also, just:
> 
>    return tpm_chip_register(chip);
> 
> Jason

/Jarkko