From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, nick <xerofoify@gmail.com>,
gleb@kernel.org, Steven Rostedt <rostedt@goodmis.org>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Another Obsolete Fix me in trace.h?
Date: Mon, 24 Nov 2014 22:00:01 +0100 [thread overview]
Message-ID: <20141124210000.GB6795@potion.brq.redhat.com> (raw)
In-Reply-To: <54730B33.1080101@siemens.com>
2014-11-24 11:40+0100, Jan Kiszka:
> On 2014-11-24 11:12, Paolo Bonzini wrote:
> > On 24/11/2014 05:36, nick wrote:
> >> Greetings Again Gleb and others,
> >> I am assuming in the code I am pasting below the fix me is obsolete now and I can remove it. :)
> >> Cheers Nick
> >> TP_printk("%s (0x%x)",
> >> __print_symbolic(__entry->exception, kvm_trace_sym_exc),
> >> /* FIXME: don't print error_code if not present */
> >> __entry->has_error ? __entry->error_code : 0)
> >> );
> >>
> >
> > No, it's not obsolete, the idea is to print only
> >
> > %s
> >
> > instead of
> >
> > %s (0x%x)
> >
> > if __entry->has_error is false. I don't know the trace API well enough
> > to know if that is possible.
>
> Last time I ran across such a scenario, it was not feasible and
> essentially required separate tracepoints. But maybe Steven knows a trick.
The format string has to be a string literal[1]; we could change it to
allow expressions[2], but what we want is almost possible through a
direct call to trace_seq_printf()[3].
The raw result would look like
#define __print(fmt, args...) ({ \
const char *buf_start = trace_seq_buffer_ptr(p); \
trace_seq_printf(p, fmt, args); \
trace_seq_putc(p, '\0'); \
buf_start; \
})
TP_printk("%s%s", [...],
__entry->has_error ? __print("(0x%x)", __entry->error_code) : "")
and would be acceptable if something __print-like made it into a ftrace
helper[4]. (Userspace won't be able to nicely print it otherwise.)
---
1: #define TP_printk(fmt, args...) fmt "\n", args
2: TP_printk(__entry->has_error ? "%s (0x%x)" : "%s", [...]
3: Already in scsi_dispatch_cmd_start or kvm_mmu_get_page tracepoints.
4: Like __print_hex or print_symbolic.
next prev parent reply other threads:[~2014-11-24 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5472B5B5.5090201@gmail.com>
2014-11-24 10:12 ` Paolo Bonzini
2014-11-24 10:40 ` Jan Kiszka
2014-11-24 21:00 ` Radim Krčmář [this message]
2014-11-24 21:19 ` Steven Rostedt
2014-11-24 21:49 ` Radim Krčmář
2014-11-26 12:40 ` Radim Krčmář
2014-11-26 14:15 ` Steven Rostedt
2014-11-26 14:49 ` Radim Krčmář
2014-11-26 15:23 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124210000.GB6795@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®