mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: Question about fixed regulator DT properties
Date: Tue, 25 Nov 2014 12:17:49 +0000	[thread overview]
Message-ID: <20141125121749.GV7712@sirena.org.uk> (raw)
In-Reply-To: <546CAB49.8030103@mentor.com>

[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]

On Wed, Nov 19, 2014 at 04:38:01PM +0200, Vladimir Zapolskiy wrote:
> Hello Mark,
> 
> On 18.11.2014 17:00, Vladimir Zapolskiy wrote:

Your mail is really quite long and all in quotes which makes it hard to
follow, brevity is really helpful to readers.

> > | regulator-boot-on | enable-active-high | GPIO polarity | GPIO output |
> > +-------------------+--------------------+---------------+-------------+
> > |        no         |         yes        |  active high  |    low      |
> > |        no         |          no        |  active low   |   high      |

> > I'd rather think that both resulting GPIO outputs are incorrect or
> > better to say do not correspond to my perception of "regulator-boot-on"
> > and "enable-active-high" DTS properties described in the documentation,
> > however above "enable-active-high" and actual GPIO polarity are the same
> > (when they are not, it is another open topic for discussion).

What you're saying seems sensible.

> > Should documentation be updated to reflect "regulator-boot-on" role that
> > a regulator is re-enabled by the kernel?

I'm confused about this.  That's the sole purpose of the flag and as far
as I can tell it's what the documentation says.

> > Should "enable-active-high" be replaced by getting GPIO flags directly?

Probably makes sense, it predates those flags by quite some time.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2014-11-25 12:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 15:00 Question about Vladimir Zapolskiy
2014-11-19 14:38 ` Question about fixed regulator DT properties Vladimir Zapolskiy
2014-11-25 12:17   ` Mark Brown [this message]
2014-11-26 17:27     ` Vladimir Zapolskiy
2014-11-26 17:53       ` Mark Brown
2014-11-26 19:13         ` Vladimir Zapolskiy
2014-11-26 19:20           ` Mark Brown
2014-11-26 19:57             ` Vladimir Zapolskiy
2014-11-26 20:36               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141125121749.GV7712@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vladimir_zapolskiy@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome