From: Mark Brown <broonie@kernel.org>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: Question about fixed regulator DT properties
Date: Wed, 26 Nov 2014 20:36:10 +0000 [thread overview]
Message-ID: <20141126203610.GY7712@sirena.org.uk> (raw)
In-Reply-To: <547630AD.1010108@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
On Wed, Nov 26, 2014 at 09:57:33PM +0200, Vladimir Zapolskiy wrote:
> If "regulator-boot-on" is specified and the regulator is untouched by
> bootloader/firmware, then the kernel simply enables it.
> As far as I understand the latter side-effect is exploited on quite many
> ARM boards, when there is no defined regulator consumer, but I agree
> that it looks hackish. My assumption is that probably fixed regulator
It's not just hackish, if the regulator actually needs to be on but has
no users it's actively broken since the core might decide to power it
off at any time for any reason. Such regulators *must* be flagged as
always-on.
> logic around "regulator-boot-on" property should be changed, so that the
> kernel will not attempt to physically re-enable/enable the
> "regulator-boot-on" regulator at all, then misusage of the property
> should gone forced by necessity of finding a proper regulator consumer.
The only boards which might be able to get away with this are
non-DT/ACPI ones which aren't getting merged anyway and it is in general
going to be better to expand the set of cases where we do the disables
(since it saves power).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-11-26 20:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 15:00 Question about Vladimir Zapolskiy
2014-11-19 14:38 ` Question about fixed regulator DT properties Vladimir Zapolskiy
2014-11-25 12:17 ` Mark Brown
2014-11-26 17:27 ` Vladimir Zapolskiy
2014-11-26 17:53 ` Mark Brown
2014-11-26 19:13 ` Vladimir Zapolskiy
2014-11-26 19:20 ` Mark Brown
2014-11-26 19:57 ` Vladimir Zapolskiy
2014-11-26 20:36 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126203610.GY7712@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®