mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/1] of: base, fix of_property_read_string_helper kernel-doc
@ 2014-11-21 12:23 Jiri Slaby
  2014-11-26 13:27 ` Grant Likely
  0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2014-11-21 12:23 UTC (permalink / raw)
  To: grant.likely
  Cc: robh+dt, devicetree, linux-kernel, Jiri Slaby, Rafael J. Wysocki,
	Mika Westerberg, Arnd Bergmann, Darren Hart

It referenced of_property_read_string_util whereas the function name
is of_property_read_string_helper.

Introduced in a87fa1d81a9fb5e9adca9820e16008c40ad09f33 (of: Fix
overflow bug in string property parsing functions). Found out when
reviewing the stable 3.12 queue.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Darren Hart <darren.hart@intel.com>
---
 drivers/of/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 37de43ef22fc..76d8307a1cd5 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1359,7 +1359,7 @@ int of_property_match_string(struct device_node *np, const char *propname,
 EXPORT_SYMBOL_GPL(of_property_match_string);
 
 /**
- * of_property_read_string_util() - Utility helper for parsing string properties
+ * of_property_read_string_helper() - Utility helper for parsing string properties
  * @np:		device node from which the property value is to be read.
  * @propname:	name of the property to be searched.
  * @out_strs:	output array of string pointers.
-- 
2.1.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] of: base, fix of_property_read_string_helper kernel-doc
  2014-11-21 12:23 [PATCH 1/1] of: base, fix of_property_read_string_helper kernel-doc Jiri Slaby
@ 2014-11-26 13:27 ` Grant Likely
  0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2014-11-26 13:27 UTC (permalink / raw)
  To: Jiri Slaby
  Cc: robh+dt, devicetree, linux-kernel, Jiri Slaby, Rafael J. Wysocki,
	Mika Westerberg, Arnd Bergmann, Darren Hart

On Fri, 21 Nov 2014 13:23:09 +0100
, Jiri Slaby <jslaby@suse.cz>
 wrote:
> It referenced of_property_read_string_util whereas the function name
> is of_property_read_string_helper.
> 
> Introduced in a87fa1d81a9fb5e9adca9820e16008c40ad09f33 (of: Fix
> overflow bug in string property parsing functions). Found out when
> reviewing the stable 3.12 queue.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Darren Hart <darren.hart@intel.com>

Applied, thanks.

g.

> ---
>  drivers/of/base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 37de43ef22fc..76d8307a1cd5 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -1359,7 +1359,7 @@ int of_property_match_string(struct device_node *np, const char *propname,
>  EXPORT_SYMBOL_GPL(of_property_match_string);
>  
>  /**
> - * of_property_read_string_util() - Utility helper for parsing string properties
> + * of_property_read_string_helper() - Utility helper for parsing string properties
>   * @np:		device node from which the property value is to be read.
>   * @propname:	name of the property to be searched.
>   * @out_strs:	output array of string pointers.
> -- 
> 2.1.3
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-26 13:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-21 12:23 [PATCH 1/1] of: base, fix of_property_read_string_helper kernel-doc Jiri Slaby
2014-11-26 13:27 ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®