* [PATCH libata/for-3.19] libata: Remove FIXME comment in atapi_request_sense()
[not found] <1417558142-2901-1-git-send-email-xerofoify@gmail.com>
@ 2014-12-04 18:05 ` Tejun Heo
0 siblings, 0 replies; only message in thread
From: Tejun Heo @ 2014-12-04 18:05 UTC (permalink / raw)
To: Nicholas Krause; +Cc: linux-ide, linux-kernel
>From 2ba520f0cd65c2e688f8beb495bb6634a61ee17b Mon Sep 17 00:00:00 2001
From: Nicholas Krause <xerofoify@gmail.com>
Date: Tue, 2 Dec 2014 17:09:02 -0500
Remove the FIXME comment in atapi_request_sense() asking whether
memset of sense buffer is necessary. The buffer may be partially or
fully filled by the device. We want it to be cleared.
tj: Updated description.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
---
Applied to libata/for-3.19 with updated description.
Thanks.
drivers/ata/libata-scsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 1db6eab..6a5fcf1 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2595,7 +2595,6 @@ static void atapi_request_sense(struct ata_queued_cmd *qc)
DPRINTK("ATAPI request sense\n");
- /* FIXME: is this needed? */
memset(cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE);
#ifdef CONFIG_ATA_SFF
--
2.1.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-12-04 18:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1417558142-2901-1-git-send-email-xerofoify@gmail.com>
2014-12-04 18:05 ` [PATCH libata/for-3.19] libata: Remove FIXME comment in atapi_request_sense() Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®