* Re: Another FIXME in libata-scsi.c [not found] <547FDDFF.7050802@gmail.com> @ 2014-12-04 18:23 ` Tejun Heo [not found] ` <5480CAEF.8030500@gmail.com> 0 siblings, 1 reply; 2+ messages in thread From: Tejun Heo @ 2014-12-04 18:23 UTC (permalink / raw) To: nick; +Cc: linux-ide, linux-kernel On Wed, Dec 03, 2014 at 11:07:27PM -0500, nick wrote: > Greetings again Tejun, > I am wondering about if the code needs improvement as it seems to not from my reading. The comment doesn't serve any purpose but it's not harming anything either. I'd just leave it alone. Thanks. -- tejun ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <5480CAEF.8030500@gmail.com>]
* Re: Another FIXME in libata-scsi.c [not found] ` <5480CAEF.8030500@gmail.com> @ 2014-12-04 21:01 ` Tejun Heo 0 siblings, 0 replies; 2+ messages in thread From: Tejun Heo @ 2014-12-04 21:01 UTC (permalink / raw) To: nick; +Cc: linux-ide, linux-kernel On Thu, Dec 04, 2014 at 03:58:23PM -0500, nick wrote: > Are you sure as it seems FIX MES mean unfinished work and issues. I > would personally remove the FIX ME part at least. It really doesn't matter unless it's actively misleading. If you have good enough justification that the comment is unnecessary / misleading, please feel free to submit a patch with accompanying rationales but it's not something we should spend time and energy collaborating on. Thanks. -- tejun ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-04 21:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <547FDDFF.7050802@gmail.com>
2014-12-04 18:23 ` Another FIXME in libata-scsi.c Tejun Heo
[not found] ` <5480CAEF.8030500@gmail.com>
2014-12-04 21:01 ` Tejun Heo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®