From: Andrew Morton <akpm@linux-foundation.org>
To: Stefan Agner <stefan@agner.ch>
Cc: Sanchayan Maity <maitysanchayan@gmail.com>,
a.zummo@towertech.it, rtc-linux@googlegroups.com,
shawn.guo@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support
Date: Fri, 5 Dec 2014 13:44:55 -0800 [thread overview]
Message-ID: <20141205134455.7901c40277cbc2093ccabfd2@linux-foundation.org> (raw)
In-Reply-To: <5536a0707e516d0f4a0c6eaf9d4d9291@agner.ch>
On Fri, 05 Dec 2014 15:54:15 +0100 Stefan Agner <stefan@agner.ch> wrote:
> It can be fixed, with something like this:
>
> @@ -346,7 +347,10 @@ static int snvs_rtc_resume(struct device *dev)
> }
> #endif
>
> -static SIMPLE_DEV_PM_OPS(snvs_rtc_pm_ops, snvs_rtc_suspend,
> snvs_rtc_resume);
> +static const struct dev_pm_ops snvs_rtc_pm_ops = {
> + .suspend_noirq = snvs_rtc_suspend,
> + .resume_noirq = snvs_rtc_resume,
> +};
>
> static const struct of_device_id snvs_dt_ids[] = {
> { .compatible = "fsl,sec-v4.0-mon-rtc-lp", },
>
>
>
> Andrew, this patch is already merged, so it would need another fix for
> this, right?
A replacement patch is OK. An incremental patch is OK too. I almost
always turn the replacement into an incremental so that I and others
can see what changed.
prev parent reply other threads:[~2014-12-05 21:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 5:58 [RESEND PATCHv2] Add SNVS clock support to rtc-snvs driver Sanchayan Maity
2014-12-03 5:58 ` [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support Sanchayan Maity
2014-12-04 9:36 ` Stefan Agner
2014-12-04 10:05 ` Alessandro Zummo
2014-12-04 12:29 ` Stefan Agner
2014-12-04 16:54 ` Alessandro Zummo
2014-12-05 0:12 ` Andrew Morton
2014-12-05 14:54 ` Stefan Agner
2014-12-05 21:44 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141205134455.7901c40277cbc2093ccabfd2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=rtc-linux@googlegroups.com \
--cc=shawn.guo@linaro.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome