From: kbuild test robot <fengguang.wu@intel.com>
To: Alan Tull <atull@opensource.altera.com>
Cc: kbuild-all@01.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH socfpga-nex] staging: fpga manager: fpga_mgr_low_level_state() can be static
Date: Wed, 10 Dec 2014 10:12:49 +0800 [thread overview]
Message-ID: <20141210021249.GA71780@lkp-sb04> (raw)
In-Reply-To: <201412101021.JoZosGm6%fengguang.wu@intel.com>
drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static?
drivers/staging/fpga/fpga-mgr.c:324:30: sparse: symbol 'fpga_mgr_groups' was not declared. Should it be static?
drivers/staging/fpga/fpga-mgr.c:365:25: sparse: symbol 'fpga_mgr_dev_pm_ops' was not declared. Should it be static?
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
fpga-mgr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fpga/fpga-mgr.c b/drivers/staging/fpga/fpga-mgr.c
index d08cb82..3216276 100644
--- a/drivers/staging/fpga/fpga-mgr.c
+++ b/drivers/staging/fpga/fpga-mgr.c
@@ -43,7 +43,7 @@ static LIST_HEAD(fpga_manager_list);
*
* This will be used to initialize framework state
*/
-int fpga_mgr_low_level_state(struct fpga_manager *mgr)
+static int fpga_mgr_low_level_state(struct fpga_manager *mgr)
{
if (!mgr || !mgr->mops || !mgr->mops->state)
return FPGA_MGR_STATE_UNKNOWN;
@@ -321,7 +321,7 @@ static const struct attribute_group fpga_mgr_group = {
.attrs = fpga_mgr_attrs,
};
-const struct attribute_group *fpga_mgr_groups[] = {
+static const struct attribute_group *fpga_mgr_groups[] = {
&fpga_mgr_group,
NULL,
};
@@ -362,7 +362,7 @@ static int fpga_mgr_resume(struct device *dev)
return 0;
}
-const struct dev_pm_ops fpga_mgr_dev_pm_ops = {
+static const struct dev_pm_ops fpga_mgr_dev_pm_ops = {
.suspend = fpga_mgr_suspend,
.resume = fpga_mgr_resume,
};
prev parent reply other threads:[~2014-12-10 2:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 2:12 [socfpga-nex:for_next-fpgamgr-without-overlays-v4 8/9] drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static? kbuild test robot
2014-12-10 2:12 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210021249.GA71780@lkp-sb04 \
--to=fengguang.wu@intel.com \
--cc=atull@opensource.altera.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®