mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH socfpga-nex] staging: fpga manager: fpga_mgr_low_level_state() can be static
  2014-12-10  2:12 [socfpga-nex:for_next-fpgamgr-without-overlays-v4 8/9] drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static? kbuild test robot
@ 2014-12-10  2:12 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2014-12-10  2:12 UTC (permalink / raw)
  To: Alan Tull; +Cc: kbuild-all, Greg Kroah-Hartman, devel, linux-kernel

drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static?
drivers/staging/fpga/fpga-mgr.c:324:30: sparse: symbol 'fpga_mgr_groups' was not declared. Should it be static?
drivers/staging/fpga/fpga-mgr.c:365:25: sparse: symbol 'fpga_mgr_dev_pm_ops' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 fpga-mgr.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/fpga/fpga-mgr.c b/drivers/staging/fpga/fpga-mgr.c
index d08cb82..3216276 100644
--- a/drivers/staging/fpga/fpga-mgr.c
+++ b/drivers/staging/fpga/fpga-mgr.c
@@ -43,7 +43,7 @@ static LIST_HEAD(fpga_manager_list);
  *
  * This will be used to initialize framework state
  */
-int fpga_mgr_low_level_state(struct fpga_manager *mgr)
+static int fpga_mgr_low_level_state(struct fpga_manager *mgr)
 {
 	if (!mgr || !mgr->mops || !mgr->mops->state)
 		return FPGA_MGR_STATE_UNKNOWN;
@@ -321,7 +321,7 @@ static const struct attribute_group fpga_mgr_group = {
 	.attrs = fpga_mgr_attrs,
 };
 
-const struct attribute_group *fpga_mgr_groups[] = {
+static const struct attribute_group *fpga_mgr_groups[] = {
 	&fpga_mgr_group,
 	NULL,
 };
@@ -362,7 +362,7 @@ static int fpga_mgr_resume(struct device *dev)
 	return 0;
 }
 
-const struct dev_pm_ops fpga_mgr_dev_pm_ops = {
+static const struct dev_pm_ops fpga_mgr_dev_pm_ops = {
 	.suspend	= fpga_mgr_suspend,
 	.resume		= fpga_mgr_resume,
 };

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [socfpga-nex:for_next-fpgamgr-without-overlays-v4 8/9] drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static?
@ 2014-12-10  2:12 kbuild test robot
  2014-12-10  2:12 ` [PATCH socfpga-nex] staging: fpga manager: fpga_mgr_low_level_state() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2014-12-10  2:12 UTC (permalink / raw)
  To: Alan Tull; +Cc: kbuild-all, Greg Kroah-Hartman, devel, linux-kernel

tree:   git://git.rocketboards.org/linux-socfpga-next for_next-fpgamgr-without-overlays-v4
head:   590b747bfa6791797c241116453acf50bc4e5dda
commit: 356ae534a603de3aa8b1cfc173a777f59273d32e [8/9] staging: fpga manager: framework core
reproduce:
  # apt-get install sparse
  git checkout 356ae534a603de3aa8b1cfc173a777f59273d32e
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static?
>> drivers/staging/fpga/fpga-mgr.c:324:30: sparse: symbol 'fpga_mgr_groups' was not declared. Should it be static?
>> drivers/staging/fpga/fpga-mgr.c:365:25: sparse: symbol 'fpga_mgr_dev_pm_ops' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-10  2:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-10  2:12 [socfpga-nex:for_next-fpgamgr-without-overlays-v4 8/9] drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static? kbuild test robot
2014-12-10  2:12 ` [PATCH socfpga-nex] staging: fpga manager: fpga_mgr_low_level_state() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®