From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] perf: Avoid horrible stack usage
Date: Wed, 17 Dec 2014 16:45:07 +0100 [thread overview]
Message-ID: <20141217154507.GA20471@krava.brq.redhat.com> (raw)
In-Reply-To: <20141217153508.GC30905@twins.programming.kicks-ass.net>
On Wed, Dec 17, 2014 at 04:35:08PM +0100, Peter Zijlstra wrote:
> On Wed, Dec 17, 2014 at 03:31:05PM +0100, Jiri Olsa wrote:
> > looks like we could also sanitize the perf_ftrace_function_call
> > in the same way.. like below (untested)
> >
> > hum, I just noticed it actually has pt_regs arg ;-)
>
> Bu if it has pt_regs should we not use that instead of filling one out
> again?
yep, I talked to Steven about that and the thing is that
it's not guaranteed on all archs.. I'll send patch that
take that in account
jirka
next prev parent reply other threads:[~2014-12-17 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 11:50 Peter Zijlstra
2014-12-17 14:31 ` Jiri Olsa
2014-12-17 15:35 ` Peter Zijlstra
2014-12-17 15:45 ` Jiri Olsa [this message]
2014-12-18 14:08 ` [PATCH] perf ftrace: Factor regs retrieval for function tracer Jiri Olsa
2014-12-18 14:20 ` Peter Zijlstra
2014-12-18 14:28 ` Jiri Olsa
2014-12-18 15:10 ` Peter Zijlstra
2015-01-14 19:19 ` [tip:perf/core] perf: Avoid horrible stack usage tip-bot for Peter Zijlstra (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217154507.GA20471@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®